From owner-freebsd-ports-bugs@FreeBSD.ORG  Sat Nov 28 22:22:50 2009
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 26B3E1065670
	for <freebsd-ports-bugs@FreeBSD.org>;
	Sat, 28 Nov 2009 22:22:50 +0000 (UTC)
	(envelope-from dan@langille.org)
Received: from nyi.unixathome.org (nyi.unixathome.org [64.147.113.42])
	by mx1.freebsd.org (Postfix) with ESMTP id EAB778FC26
	for <freebsd-ports-bugs@FreeBSD.org>;
	Sat, 28 Nov 2009 22:22:49 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by nyi.unixathome.org (Postfix) with ESMTP id 3811C50850;
	Sat, 28 Nov 2009 22:22:49 +0000 (GMT)
X-Virus-Scanned: amavisd-new at unixathome.org
Received: from nyi.unixathome.org ([127.0.0.1])
	by localhost (nyi.unixathome.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id lbWIoLiDoj+X; Sat, 28 Nov 2009 22:22:48 +0000 (GMT)
Received: from smtp-auth.unixathome.org (smtp-auth.unixathome.org [10.4.7.7])
	(Authenticated sender: hidden)
	by nyi.unixathome.org (Postfix) with ESMTPSA id 7657C5084D  ;
	Sat, 28 Nov 2009 22:22:48 +0000 (GMT)
Message-ID: <4B11A2B6.6050505@langille.org>
Date: Sat, 28 Nov 2009 17:22:46 -0500
From: Dan Langille <dan@langille.org>
User-Agent: Thunderbird 2.0.0.23 (Windows/20090812)
MIME-Version: 1.0
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
References: <200911282210.nASMA0Mh042872@freefall.freebsd.org>
In-Reply-To: <200911282210.nASMA0Mh042872@freefall.freebsd.org>
Content-Type: multipart/mixed; boundary="------------090301030208050101060006"
Cc: 
Subject: Re: ports/140981: [PATCH] security/logcheck - use correct .conf file
 location in message
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Nov 2009 22:22:50 -0000

This is a multi-part message in MIME format.
--------------090301030208050101060006
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

The patch file seems to be crappy.

See attached:


--------------090301030208050101060006
Content-Type: text/plain;
 name="logcheck.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="logcheck.diff"

diff -ruN /usr/ports/security/logcheck/files/patch-src__logcheck logcheck/files/patch-src__logcheck
--- /usr/ports/security/logcheck/files/patch-src__logcheck	2008-09-11 00:30:09.000000000 +0000
+++ logcheck/files/patch-src__logcheck	2009-11-28 21:55:32.000000000 +0000
@@ -95,6 +95,15 @@
         fi
  	
      fi
+@@ -168,7 +168,7 @@
+ ${TMPDIR:+Check temporary directory: $TMPDIR
+ }
+ Also verify that the logcheck user can read all files referenced in
+-/etc/logcheck/logcheck.logfiles!
++${LOGFILES_LIST}!
+ 
+ $(export)
+ EOF
 @@ -212,8 +195,7 @@
  	    mkdir $cleaned \
  	        || error "Could not make dir $cleaned for cleaned rulefiles."

--------------090301030208050101060006--