From owner-freebsd-current@FreeBSD.ORG  Mon Apr  6 21:14:06 2015
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 633E56FD;
 Mon,  6 Apr 2015 21:14:06 +0000 (UTC)
Received: from mail-ie0-x235.google.com (mail-ie0-x235.google.com
 [IPv6:2607:f8b0:4001:c03::235])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 319487BE;
 Mon,  6 Apr 2015 21:14:06 +0000 (UTC)
Received: by iedfl3 with SMTP id fl3so35646276ied.1;
 Mon, 06 Apr 2015 14:14:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=fUEIp1UaE2OGUxSKbc0J+V0ccgUn4Uq20p24pHkmyno=;
 b=tJdAgXN1OiAGdcwOWWPVz/UoMFz5Sm9fjSAqS6eN6AAqq3Ug+RVlTf8HODORrad2hw
 5u2Xrx4iqcj1bwbZKiLldJeZM1ADWsF+sdikZ8xs+FFKzHiBoJdyPBL54ffRQ4lXJJMy
 URzinVfMA4gGGuSZ5h36koLhgopotQOijfugkvcuCCvW7ibqnJGOEkrsLgRac/VCp0Y3
 dOw+23YbP4XqAJaQr1kta54HcTN0VAAJvN0CQck/XE3rSlnDkitPQYQFySIB50iivbGk
 sd7jvnWCCtheu+TiJigIFIIeHW5cfPEttws6Zn4Eer3mIm33G3CwI48A6UXjgFEy2KmG
 SjDg==
MIME-Version: 1.0
X-Received: by 10.42.109.12 with SMTP id j12mr21933423icp.22.1428354845358;
 Mon, 06 Apr 2015 14:14:05 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.36.17.194 with HTTP; Mon, 6 Apr 2015 14:14:05 -0700 (PDT)
In-Reply-To: <70135.1428354681@critter.freebsd.dk>
References: <5514CC6D.3020607@badgerio.us>
 <2033248.Eu3RHS8lTG@ralph.baldwin.cx>
 <70135.1428354681@critter.freebsd.dk>
Date: Mon, 6 Apr 2015 14:14:05 -0700
X-Google-Sender-Auth: 4XHmmoeYJrJuZ3m3QNOEwNYnVpg
Message-ID: <CAJ-Vmo=msh--7sWjQaM2P7bo0o3VyAaba0DfYwCVvHZS05dYmw@mail.gmail.com>
Subject: Re: Early use of log() does not end up in kernel msg buffer
From: Adrian Chadd <adrian@freebsd.org>
To: Poul-Henning Kamp <phk@phk.freebsd.dk>
Content-Type: text/plain; charset=UTF-8
Cc: Eric Badger <eric@badgerio.us>,
 freebsd-current <freebsd-current@freebsd.org>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Apr 2015 21:14:06 -0000

On 6 April 2015 at 14:11, Poul-Henning Kamp <phk@phk.freebsd.dk> wrote:
> --------
> In message <2033248.Eu3RHS8lTG@ralph.baldwin.cx>, John Baldwin writes:
>
>>I think phk@ broke this back in 70239.  Before that the log() function did
>>this:
>>
>>log()
>>{
>>
>>       /* log to the msg buffer */
>>       kvprintf(fmt, msglogchar, ...);
>>
>>       if (!log_open) {
>>               /* log to console */
>>               kvprintf(fmt, putchar, ...);
>>       }
>>}
>>
>>I think your patch is fine unless phk@ (cc'd) has a reason for not wanting to
>>do this.
>
> The reason was systems not running syslog having slow serial consoles.

.. and that's still a thing, btw.



-adrian