Date: Sun, 11 Nov 2012 21:49:41 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Roman Divacky <rdivacky@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r242889 - head/sys/dev/xen/netback Message-ID: <20121111194941.GW73505@kib.kiev.ua> In-Reply-To: <201211111042.qABAgYk4066339@svn.freebsd.org> References: <201211111042.qABAgYk4066339@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--HECHSKL9QsOKTVdc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 11, 2012 at 10:42:34AM +0000, Roman Divacky wrote: > Author: rdivacky > Date: Sun Nov 11 10:42:34 2012 > New Revision: 242889 > URL: http://svnweb.freebsd.org/changeset/base/242889 >=20 > Log: > Change the XNB_ASSERT from a statement expression to do-while(0) as its > result is never used. >=20 > Modified: > head/sys/dev/xen/netback/netback_unit_tests.c >=20 > Modified: head/sys/dev/xen/netback/netback_unit_tests.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/dev/xen/netback/netback_unit_tests.c Sun Nov 11 08:22:58 201= 2 (r242888) > +++ head/sys/dev/xen/netback/netback_unit_tests.c Sun Nov 11 10:42:34 201= 2 (r242889) > @@ -62,7 +62,7 @@ __FBSDID("$FreeBSD$"); > * iff the assertion failed. Note the implied parameters buffer and > * buflen > */ > -#define XNB_ASSERT(cond) ({ \ > +#define XNB_ASSERT(cond) do ( \ > int passed =3D (cond); \ > char *_buffer =3D (buffer); \ > size_t _buflen =3D (buflen); \ > @@ -71,7 +71,7 @@ __FBSDID("$FreeBSD$"); > strlcat(_buffer, ":" TOSTRING(__LINE__) \ > " Assertion Error: " #cond "\n", _buflen); \ > } \ > - ! passed; }) > + } while (0) > =20 > =20 > /** Look at r240747. --HECHSKL9QsOKTVdc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlCgAVUACgkQC3+MBN1Mb4hXIgCgy/cm8gA3aLndTR4xEFwvyGio HH0AoJDMvFelLECsRPhc99UFXoorRTNI =xJNq -----END PGP SIGNATURE----- --HECHSKL9QsOKTVdc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121111194941.GW73505>