From owner-svn-ports-head@freebsd.org  Thu Jul 26 07:16:36 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1EA461044F27;
 Thu, 26 Jul 2018 07:16:36 +0000 (UTC)
 (envelope-from yuri@freebsd.org)
Received: from shell1.rawbw.com (shell1.rawbw.com [198.144.192.42])
 by mx1.freebsd.org (Postfix) with ESMTP id A3BFC8236C;
 Thu, 26 Jul 2018 07:16:35 +0000 (UTC)
 (envelope-from yuri@freebsd.org)
Received: from yv.noip.me (c-24-4-131-132.hsd1.ca.comcast.net [24.4.131.132])
 (authenticated bits=0)
 by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id w6Q7GX0d057618
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO);
 Thu, 26 Jul 2018 00:16:35 -0700 (PDT)
 (envelope-from yuri@freebsd.org)
X-Authentication-Warning: shell1.rawbw.com: Host
 c-24-4-131-132.hsd1.ca.comcast.net [24.4.131.132] claimed to be yv.noip.me
Reply-To: yuri@freebsd.org
Subject: Re: svn commit: r475335 - head/devel/liteide
To: Alexey Dokuchaev <danfe@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
References: <201807252025.w6PKPsxQ097871@repo.freebsd.org>
 <20180726064408.GC77261@FreeBSD.org>
 <32e60b17-116f-e431-872b-903412e4abd1@freebsd.org>
 <20180726070858.GA93790@FreeBSD.org>
From: Yuri <yuri@freebsd.org>
Message-ID: <faa15cf5-fb73-3665-4f17-f63ca0f92502@freebsd.org>
Date: Thu, 26 Jul 2018 00:16:32 -0700
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <20180726070858.GA93790@FreeBSD.org>
Content-Language: en-US
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.27
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Jul 2018 07:16:36 -0000

On 7/26/18 12:08 AM, Alexey Dokuchaev wrote:
> Yes, I know, but as long as you never check against the default FLAVOR,
> you don't need it.
>
>>> Because qt5 is default flavor, and you're checking for qt4 first (qt5 is
>>> in .else branch) and never for .if ${FLAVOR} == qt5.
>> Framework checks that flavor is in the list. Here, when flavor isn't
>> qt4, it is safe to assume that it is qt5.
> Thank you captain.  Not sure why you had to explain this, but that does
> not change the point that you don't need FLAVOR?=${FLAVORS:[1]}.  :U
> will protect you from undefined variable, and it would be defined in the
> Qt4 case because it's not the default flavor.


I think it's conceptually simpler to have this line, so that FLAVOR is 
always defined after it.

This line increases readability and understandability,  IMO.


Yuri