From owner-svn-src-all@FreeBSD.ORG Sat Nov 26 19:01:08 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 38EB91065784; Sat, 26 Nov 2011 19:01:08 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25]) by mx1.freebsd.org (Postfix) with ESMTP id DDD2B8FC13; Sat, 26 Nov 2011 19:01:07 +0000 (UTC) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 0AF2B25D389E; Sat, 26 Nov 2011 19:01:06 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 3D136BD5BB9; Sat, 26 Nov 2011 19:01:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id lw1BkIwpKW+l; Sat, 26 Nov 2011 19:01:05 +0000 (UTC) Received: from nv.sbone.de (nv.sbone.de [IPv6:fde9:577b:c1a9:31::2013:138]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id A20D0BD5BB7; Sat, 26 Nov 2011 19:01:04 +0000 (UTC) Date: Sat, 26 Nov 2011 19:01:04 +0000 (UTC) From: "Bjoern A. Zeeb" To: Dimitry Andric In-Reply-To: <201111260326.pAQ3Q7Qw071782@svn.freebsd.org> Message-ID: References: <201111260326.pAQ3Q7Qw071782@svn.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r227987 - in head: . lib share/mk X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Nov 2011 19:01:08 -0000 On Sat, 26 Nov 2011, Dimitry Andric wrote: > Author: dim > Date: Sat Nov 26 03:26:06 2011 > New Revision: 227987 > URL: http://svn.freebsd.org/changeset/base/227987 > > Log: > Fix breakage after r227983; lib/libcxxrt still got built, because it was > not disabled in the usual way (by adding it to __DEFAULT_NO_OPTIONS in > share/mk/bsd.own.mk), and because the test for MK_LIBCPLUSPLUS in > Makefile.inc1 was incorrect. > > Pointy hat to: dim Can you please also add an tools/build/options/ entry and re-gen src.conf(5)? > Modified: > head/Makefile.inc1 > head/lib/Makefile > head/share/mk/bsd.own.mk > > Modified: head/Makefile.inc1 > ============================================================================== > --- head/Makefile.inc1 Sat Nov 26 01:44:37 2011 (r227986) > +++ head/Makefile.inc1 Sat Nov 26 03:26:06 2011 (r227987) > @@ -1218,7 +1218,7 @@ _startup_libs+= lib/csu/${MACHINE_CPUARC > _startup_libs+= gnu/lib/libgcc > _startup_libs+= lib/libcompiler_rt > _startup_libs+= lib/libc > -.if defined(MK_LIBCPLUSPLUS) > +.if ${MK_LIBCPLUSPLUS} != "no" > _startup_libs+= lib/libcxxrt > .endif > > > Modified: head/lib/Makefile > ============================================================================== > --- head/lib/Makefile Sat Nov 26 01:44:37 2011 (r227986) > +++ head/lib/Makefile Sat Nov 26 03:26:06 2011 (r227987) > @@ -48,13 +48,9 @@ SUBDIR_ORDERED= ${_csu} \ > libsbuf \ > libtacplus \ > libutil \ > - ${_libypclnt} > - > -.if ${MK_LIBCPLUSPLUS} != "no" > -SUBDIR_ORDERED+=libcxxrt\ > - libc++ > -.endif > - > + ${_libypclnt} \ > + ${_libcxxrt} \ > + ${_libcplusplus} > > SUBDIR= ${SUBDIR_ORDERED} \ > libalias \ > @@ -209,6 +205,11 @@ _libsmb= libsmb > _libmp= libmp > .endif > > +.if ${MK_LIBCPLUSPLUS} != "no" > +_libcxxrt= libcxxrt > +_libcplusplus= libc++ > +.endif > + > .if ${MK_PMC} != "no" > _libpmc= libpmc > .endif > > Modified: head/share/mk/bsd.own.mk > ============================================================================== > --- head/share/mk/bsd.own.mk Sat Nov 26 01:44:37 2011 (r227986) > +++ head/share/mk/bsd.own.mk Sat Nov 26 03:26:06 2011 (r227987) > @@ -413,6 +413,7 @@ __DEFAULT_NO_OPTIONS = \ > HESIOD \ > ICONV \ > IDEA \ > + LIBCPLUSPLUS \ > OFED > > # > @@ -553,8 +554,6 @@ MK_GCC:= no > MK_GDB:= no > .endif > > -MK_LIBCPLUSPLUS?= no > - > # > # Set defaults for the MK_*_SUPPORT variables. > # > -- Bjoern A. Zeeb You have to have visions! Stop bit received. Insert coin for new address family.