From owner-cvs-all@FreeBSD.ORG Fri May 4 19:47:05 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C983A16A400; Fri, 4 May 2007 19:47:05 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 50E6213C489; Fri, 4 May 2007 19:47:05 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l44Jkvpv050250; Fri, 4 May 2007 15:46:59 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Rui Paulo Date: Fri, 4 May 2007 15:45:08 -0400 User-Agent: KMail/1.9.6 References: <200705021750.l42HoaMj067787@repoman.freebsd.org> <86hcqs612o.wl%rpaulo@fnop.net> In-Reply-To: <86hcqs612o.wl%rpaulo@fnop.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200705041545.09141.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 04 May 2007 15:46:59 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3205/Fri May 4 06:50:21 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 mptable_pci.c msi.c nexus.c src/sys/amd64/include intr_machdep.h src/sys/amd64/pci pci_bus.c src/sys/dev/acpica acpi_pcib_acpi.c acpi_pcib_pci.c src/sys/dev/pci pci.c pci_if.m pci_pci.c pci_private.h pcib_if.m ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 19:47:05 -0000 On Friday 04 May 2007 11:49:35 am Rui Paulo wrote: > At Wed, 2 May 2007 17:50:36 +0000 (UTC), > John Baldwin wrote: > > > > jhb 2007-05-02 17:50:36 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/amd64/amd64 mptable_pci.c msi.c nexus.c > > sys/amd64/include intr_machdep.h > > sys/amd64/pci pci_bus.c > > sys/dev/acpica acpi_pcib_acpi.c acpi_pcib_pci.c > > sys/dev/pci pci.c pci_if.m pci_pci.c pci_private.h > > pcib_if.m pcib_private.h pcivar.h > > sys/i386/i386 mptable_pci.c msi.c nexus.c > > sys/i386/include intr_machdep.h > > sys/i386/pci pci_bus.c > > Log: > > Revamp the MSI/MSI-X code a bit to achieve two main goals: > > - Simplify the amount of work that has be done for each architecture by > > pushing more of the truly MI code down into the PCI bus driver. > > - Don't bind MSI-X indicies to IRQs so that we can allow a driver to map > > multiple MSI-X messages into a single IRQ when handling a message > > shortage. > > > With this change, I think, I get a WITNESS panic when booting the > second core on my MacBook > > After SMP: AP #1 Launched, I get this panic: > panic: blockable sleep lock (sx) msi @ i386/i386/msi.c:374 > > The backtrace is: > witness_checkorder() > _sx_lock() > msi_map() > nexus_map_msi() > acpi_pcib_map_msi() > pcib_map_msi() > pci_remap_msi_irq() > msi_assign_cpu() > > Any idea why? Hmm, I know why, I'll look at it. I think msi_assign_cpu() is called while holding a lock and that is leading to the problem. -- John Baldwin