From owner-svn-src-stable@freebsd.org  Tue Sep 15 01:34:21 2015
Return-Path: <owner-svn-src-stable@freebsd.org>
Delivered-To: svn-src-stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8672CA04B21;
 Tue, 15 Sep 2015 01:34:21 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 73F0F106B;
 Tue, 15 Sep 2015 01:34:21 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 728CD1945; Tue, 15 Sep 2015 01:34:21 +0000 (UTC)
Date: Tue, 15 Sep 2015 01:34:21 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Aleksandr Rybalko <ray@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject: Re: svn commit: r287782 - stable/10/sys/dev/vt
Message-ID: <20150915013421.GA59565@FreeBSD.org>
References: <201509141442.t8EEg7ao012596@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201509141442.t8EEg7ao012596@repo.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-src-stable@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for all the -stable branches of the src tree
 <svn-src-stable.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-stable>, 
 <mailto:svn-src-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable/>
List-Post: <mailto:svn-src-stable@freebsd.org>
List-Help: <mailto:svn-src-stable-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-stable>,
 <mailto:svn-src-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Sep 2015 01:34:21 -0000

On Mon, Sep 14, 2015 at 02:42:07PM +0000, Aleksandr Rybalko wrote:
> New Revision: 287782
> URL: https://svnweb.freebsd.org/changeset/base/287782
> 
> Log:
>   MFC: r272715
>   	Allow vt(4) to disable terminal bell with
>       `sysctl kern.vt.bell_enable=0`, similar as syscons(4) do.
> [...]
> +VT_SYSCTL_INT(enable_bell, 1, "Enable bell");

I think you've meant `sysctl kern.vt.enable_bell=0' in the commit log.

> +	if (!vt_enable_bell)
> +		return;
> +
>  	if (vd->vd_flags & VDF_QUIET_BELL)
>  		return;

Hm, I'm wondering why having another sysctl is required when there's already
a way to shut the bell up with VDF_QUIET_BELL flag?

Also, there's certain naming inconsistency between syscons(4) and vt(4).
On my stable/8 laptop, I see this:

    $ sysctl -d hw.syscons.bell
    hw.syscons.bell: enable bell

On my -CURRENT desktop, this:

    $ sysctl -d kern.vt.enable_bell
    kern.vt.enable_bell: Enable bell

./danfe