From owner-svn-src-head@freebsd.org Mon Aug 10 22:42:39 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 537223AF777; Mon, 10 Aug 2020 22:42:39 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BQWFC1XyJz4snd; Mon, 10 Aug 2020 22:42:39 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from [192.168.1.10] (c-98-207-126-143.hsd1.ca.comcast.net [98.207.126.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 0B63A17E49; Mon, 10 Aug 2020 22:42:37 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.39.20071300 Date: Mon, 10 Aug 2020 15:42:37 -0700 Subject: Re: svn commit: r364076 - head/sys/fs/devfs From: Ravi Pokala To: Mateusz Guzik , , , Message-ID: <7EDE5621-FB3C-4FA5-A925-30F2367ADEBD@panasas.com> Thread-Topic: svn commit: r364076 - head/sys/fs/devfs References: <202008101146.07ABkeAw039895@repo.freebsd.org> In-Reply-To: <202008101146.07ABkeAw039895@repo.freebsd.org> Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2020 22:42:39 -0000 -----Original Message----- From: on behalf of Mateusz Guzik Date: 2020-08-10, Monday at 04:46 To: , , Subject: svn commit: r364076 - head/sys/fs/devfs Author: mjg Date: Mon Aug 10 11:46:39 2020 New Revision: 364076 URL: https://svnweb.freebsd.org/changeset/base/364076 Log: devfs: bool -> int Fixes buildworld after r364069 It was returning the result of a "!=" test; is that not a bool? -Ravi (rpokala@) Modified: head/sys/fs/devfs/devfs.h head/sys/fs/devfs/devfs_devs.c Modified: head/sys/fs/devfs/devfs.h ============================================================================== --- head/sys/fs/devfs/devfs.h Mon Aug 10 10:58:43 2020 (r364075) +++ head/sys/fs/devfs/devfs.h Mon Aug 10 11:46:39 2020 (r364076) @@ -192,7 +192,7 @@ char *devfs_fqpn(char *, struct devfs_mount *, struct struct componentname *); void devfs_delete(struct devfs_mount *, struct devfs_dirent *, int); void devfs_dirent_free(struct devfs_dirent *); -bool devfs_populate_needed(struct devfs_mount *dm); +int devfs_populate_needed(struct devfs_mount *dm); void devfs_populate(struct devfs_mount *); void devfs_cleanup(struct devfs_mount *); void devfs_unmount_final(struct devfs_mount *); Modified: head/sys/fs/devfs/devfs_devs.c ============================================================================== --- head/sys/fs/devfs/devfs_devs.c Mon Aug 10 10:58:43 2020 (r364075) +++ head/sys/fs/devfs/devfs_devs.c Mon Aug 10 11:46:39 2020 (r364076) @@ -659,7 +659,7 @@ devfs_populate_loop(struct devfs_mount *dm, int cleanu return (0); } -bool +int devfs_populate_needed(struct devfs_mount *dm) {