From owner-svn-src-all@freebsd.org Wed Dec 20 20:02:24 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CA593EA103D for ; Wed, 20 Dec 2017 20:02:24 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AC0E77F60A for ; Wed, 20 Dec 2017 20:02:24 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: a8d0b1df-e5c0-11e7-8486-0934409070aa X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.78.92.27 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.78.92.27]) by outbound1.ore.mailhop.org (Halon) with ESMTPSA id a8d0b1df-e5c0-11e7-8486-0934409070aa; Wed, 20 Dec 2017 20:02:09 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id vBKK2FYi001773; Wed, 20 Dec 2017 13:02:15 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1513800135.29087.25.camel@freebsd.org> Subject: Re: svn commit: r327031 - in head/sys: conf dev/ixgbe modules/ix modules/ixv From: Ian Lepore To: Eric Joyner , Mark Johnston , cramerj@intel.com Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Wed, 20 Dec 2017 13:02:15 -0700 In-Reply-To: References: <201712201815.vBKIF6IN062349@repo.freebsd.org> <20171220193237.GA11032@raichu> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2017 20:02:24 -0000 On Wed, 2017-12-20 at 19:47 +0000, Eric Joyner wrote: > On Wed, Dec 20, 2017 at 11:32 AM Mark Johnston wrote: > > > > > On Wed, Dec 20, 2017 at 06:15:06PM +0000, Eric Joyner wrote: > > > > > > Author: erj > > > Date: Wed Dec 20 18:15:06 2017 > > > New Revision: 327031 > > > URL: https://svnweb.freebsd.org/changeset/base/327031 > > > > > > Log: > > >   ixgbe(4): Convert driver to use iflib > > > [...] > > This seems to have broken at least the i386 kernel build. Could you > > please take a look? > > > > https://ci.freebsd.org/job/FreeBSD-head-i386-build/5330/console > > We probably missed this because we pretty much only use amd64 for testing; > it looks like for that error we can just change that ULONG to a UQUAD. I'll > add Jeb to this thread. > > - Eric A good way to avoid such trouble when touching kernel/module code that compiles on multiple arches is to do a "make lintkernels". Before you can do that, you need to do "make kernel-toolchains" just once, which may take a while -- it has to build clang for each arch, which is a bit annoying since every instance of clang is already a cross-compiler and our build process doesn't make use of that fact. -- Ian