From nobody Wed May 27 21:46:38 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gQjqz13kfz6fkxD for ; Wed, 27 May 2026 21:46:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gQjqy5ZF1z3Y52 for ; Wed, 27 May 2026 21:46:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779918398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tymeJnaUKMxAJdvwHL3ZHJBdTnCKWrB1q/qYm8pPedA=; b=Pu9C95asOsM+EPOu5kIWkidGrxPH6Dvy2i+URgG7A+NgBjrEaEBLxJE6rIzTSK2TrzrSEK QD8xnFEW3vh+Jz0Hebe7LhH59d3+65gVPbioakDAXf8PKUTgU7xTF2dRk9VTRnyeSLC9XG rpfh7/3nqbEOru1tzeWWZs93ECqzK1b6wxHdSFLhgr6fg2rek7bZDXvmgYgs0NYpym13d8 Z4gKzkSHT3frLmGSv5iuD1n3ix/T9h29D1NBP2l0I23dzpZev4pXToAedg10f3sTN5QR2M bdM403Bk1SWvwz81WaSXwTTJh/6wiRM09X2J+DaGcp1mnDjJ2apqcB/Ou61W5g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779918398; a=rsa-sha256; cv=none; b=A1nhiEe/ILgqnDpZPKqrt/ex4aq57OC9fB8/+cB37maYvYsA8R3pnPuwcsPOZUpNPGYn+N nad/K9hyV3nsXPNVyh+gemTGlde49/VIk1wQ5wTAz7iqnk8XgToUc7HTEarCILtM73L33H wsKJAHwQRUSUdnrBPXbBI2Bnh00dUuFQTpnNieiC6IEb1IhgzFSMo2y/3lg7Y4RjvxuB32 u9g6OXEOhDOHtYlxcLOeRs25mZSqCGa09fgwJggieylBVhXLdeAGrHssgVlf0gshWn0dHZ SbOwJmGS6gkIvTXDgd99zJZvhnoRSpT8TRjZqiNneEaJJTQGX3im+P3qsKfbEw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779918398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tymeJnaUKMxAJdvwHL3ZHJBdTnCKWrB1q/qYm8pPedA=; b=DBB8CPv0wzoOkT0y4a55Y4WdjF/wMjsexDKVO285Sn7+ALOJorqGfe+cohT2BNCWg4A1r1 a4/4HuFZ8w6hqcWCQ0xje/OT9MPn/KsMhK9XFigVVD9uLGzpriQOHf27DiNYE49s6ynK+c JT7A4bdgS5CqA3BsIoWk7Jp+pVC0HsjiAjzZOuqWdHCeHEIGfnnLwVuBtfdNghhA8J5kE1 aBzlWBDilvzjD9eHEJlsO/xnz5SCr66o4M/+KdnHyGXvSYLeyo2/CsmBaKrNHkE/1FZolS C0TS/DHysBkCyK0QQtVA8Z5dOoWSXHlmS0O/J+Cb20JrgU6Gx7ptfLkh39OOfQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gQjqy4tYRz2dx for ; Wed, 27 May 2026 21:46:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 27286 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 27 May 2026 21:46:38 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Alex Richardson From: Dimitry Andric Subject: git: 5d64055eaaf2 - stable/14 - netmap: silence -Wdefault-const-init-field-unsafe warning List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 5d64055eaaf259ccb72a785bf5c2297e87dfa103 Auto-Submitted: auto-generated Date: Wed, 27 May 2026 21:46:38 +0000 Message-Id: <6a17663e.27286.165b89e7@gitrepo.freebsd.org> The branch stable/14 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=5d64055eaaf259ccb72a785bf5c2297e87dfa103 commit 5d64055eaaf259ccb72a785bf5c2297e87dfa103 Author: Alex Richardson AuthorDate: 2025-12-16 18:09:57 +0000 Commit: Dimitry Andric CommitDate: 2026-05-27 21:41:14 +0000 netmap: silence -Wdefault-const-init-field-unsafe warning The netmap_ring struct starts with various const members and rencent clang warns about leaving them uninitialized. Having them const in the first place is highly suspicious since they are updated with various macros but using hand-coded __DECONST(). But fixing that is a more invasive change that I am unable to test. ``` .../freebsd/sys/dev/netmap/netmap_kloop.c:320:21: error: default initialization of an object of type 'struct netmap_ring' with const member leaves the object uninitialized [-Werror,-Wdefault-const-init-field-unsafe] 320 | struct netmap_ring shadow_ring; /* shadow copy of the netmap_ring */ | ^ .../freebsd/sys/net/netmap.h:290:16: note: member 'buf_ofs' declared 'const' here 290 | const int64_t buf_ofs; | ^ ``` Test Plan: Compiles Reviewed by: vmaffione, jhb MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D52568 (cherry picked from commit 2ed21f90906b230476d3f12ff9dce0e2c4642af2) --- sys/dev/netmap/netmap_kloop.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/dev/netmap/netmap_kloop.c b/sys/dev/netmap/netmap_kloop.c index 005b9af2a3da..65c4fd89e0d5 100644 --- a/sys/dev/netmap/netmap_kloop.c +++ b/sys/dev/netmap/netmap_kloop.c @@ -161,7 +161,8 @@ netmap_sync_kloop_tx_ring(const struct sync_kloop_ring_args *a) struct netmap_kring *kring = a->kring; struct nm_csb_atok *csb_atok = a->csb_atok; struct nm_csb_ktoa *csb_ktoa = a->csb_ktoa; - struct netmap_ring shadow_ring; /* shadow copy of the netmap_ring */ + /* shadow copy of the netmap_ring */ + struct netmap_ring shadow_ring = {0}; #ifdef SYNC_KLOOP_POLL bool more_txspace = false; #endif /* SYNC_KLOOP_POLL */ @@ -317,7 +318,8 @@ netmap_sync_kloop_rx_ring(const struct sync_kloop_ring_args *a) struct netmap_kring *kring = a->kring; struct nm_csb_atok *csb_atok = a->csb_atok; struct nm_csb_ktoa *csb_ktoa = a->csb_ktoa; - struct netmap_ring shadow_ring; /* shadow copy of the netmap_ring */ + /* shadow copy of the netmap_ring */ + struct netmap_ring shadow_ring = {0}; int dry_cycles = 0; #ifdef SYNC_KLOOP_POLL bool some_recvd = false;