From owner-freebsd-hackers@FreeBSD.ORG Sun Nov 30 04:22:00 2008 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 94F981065686 for ; Sun, 30 Nov 2008 04:22:00 +0000 (UTC) (envelope-from eitanadlerlist@gmail.com) Received: from rn-out-0910.google.com (rn-out-0910.google.com [64.233.170.184]) by mx1.freebsd.org (Postfix) with ESMTP id 4B8818FC14 for ; Sun, 30 Nov 2008 04:21:59 +0000 (UTC) (envelope-from eitanadlerlist@gmail.com) Received: by rn-out-0910.google.com with SMTP id j71so1509381rne.12 for ; Sat, 29 Nov 2008 20:21:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:user-agent :mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:openpgp:content-type:content-transfer-encoding :from; bh=6Eu656SLvavDxVRgm2Wq4QiXsv7rvE8ZClOCXqawhzY=; b=nlNOD/6UIBMnvh4D20ItN9efOvVBIGjtQDo4aW7ZGwWKAvn4HpX8f7IV/LGfBo63g2 zav5YzVt+QUngqFHd4bl3uYQYIiPLiyrGPkOac0XlEaXv9YSpAxSvYCefq3KmkjJQ6DT FJ4t+BHJBO72bSpmUlufq1fQcIgbfGlDdeGP8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:user-agent:mime-version:to:cc:subject:references :in-reply-to:x-enigmail-version:openpgp:content-type :content-transfer-encoding:from; b=O5oJs8PEZ6+eSu4BRhWL4vEpq/t5PBkI7cA+TJH7iBIphkiEiN+OnbSr9p4+4phBDR ogmv7AxfGusIsl5tEE1f3EK372WVk8TcR5F/dpn8hyPsUu7m6lbWxUvIdHycdiUrYJsE fie3N355JRzXi/6kMA91zbBOMutXcwHIQnRl4= Received: by 10.90.71.15 with SMTP id t15mr5227765aga.90.1228018919161; Sat, 29 Nov 2008 20:21:59 -0800 (PST) Received: from aargh.lan (ool-182d26f3.dyn.optonline.net [24.45.38.243]) by mx.google.com with ESMTPS id 1sm3292777agb.20.2008.11.29.20.21.57 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 29 Nov 2008 20:21:58 -0800 (PST) Message-ID: <493214DC.2080904@gmail.com> Date: Sat, 29 Nov 2008 23:21:48 -0500 User-Agent: Mozilla (X11; U; FreeBSD i386; en-US; ) Gecko Thunderbird Mnenhy/0.7.5.666 MIME-Version: 1.0 To: d@delphij.net References: <49320FF7.4040901@gmail.com> <4932122A.8070209@delphij.net> In-Reply-To: <4932122A.8070209@delphij.net> X-Enigmail-Version: 0.95.7 OpenPGP: id=E9C2CCD1; url=pgp.mit.edu Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit From: Eitan Adler Cc: freebsd-hackers@freebsd.org Subject: Re: change to ee.c X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Nov 2008 04:22:00 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Xin LI wrote: > Hi, Eitan, > Tanks for interested in this but I'm afraid that your patch is > incorrect. mkstemp returns a file descriptor rather than a string > pointer, therefore, the subsequent open() would have undefined behavior. > It looks like that we actually want fd = mkstemp() here. Thanks. If this is the case how come gcc did not return any warnings? > > Note that we may want to bring vendor fixes before making any changes to > reduce duplicated work... I was not aware that this was a third party program. I'll look around and see if this was fixed. I'm sort of learning C by fixing these minor bugs so any help is appreciated. > > Cheers, - -- Eitan Adler GNU Key fingerptrint: 2E13 BC16 5F54 0FBD 62ED 42B6 B65F 24AB E9C2 CCD1 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkkyFNwACgkQtl8kq+nCzNGlRgCeJDMfvnR0ZVtz/k/OjDlrKUUP 3xwAniOJpgueqFh3KVKhk7hS9GFE9fqD =gTGT -----END PGP SIGNATURE-----