From owner-svn-src-head@freebsd.org Thu Nov 30 12:16:52 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1DC73E54C5C; Thu, 30 Nov 2017 12:16:52 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-vk0-x244.google.com (mail-vk0-x244.google.com [IPv6:2607:f8b0:400c:c05::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C68582A1F; Thu, 30 Nov 2017 12:16:51 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-vk0-x244.google.com with SMTP id f73so3265880vki.3; Thu, 30 Nov 2017 04:16:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=SO+pTzDkENXlmp1LdFZc8+YX3TC3E279XS2SacQF++8=; b=jmbxIgCTi0qgx6alvXVpnUdGMYHd+piwz9Gc1mVozPSoU5lul45EQBpQURgXcxQSR7 Z+nH+Ojmb/K90HvuzO6RfqotdjrVeooEUKKQxPKQrU1Cd47Y11xl382aI3JBINt0qnzU HRHSyaO+v8WxzMC9kE8/NV0DwOQCCZps3WVBZiMN2hquP4JvcXKHNhDNXG2xwmcUHbZz S7Yy2EOvkyW0wnofF0wTEDdL2h/wUYceJIAqxc3zmvIyvqCSTxESfHxL6vwqP6idjJLk SsL4O3AZ28n1FsMzfIu3woKfwR1Ch2q1KtFxZMcbQb1EOvM7tXwbnp54hOx/HiQE/VWo MBbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=SO+pTzDkENXlmp1LdFZc8+YX3TC3E279XS2SacQF++8=; b=pLZwFPNRRl3ajAK/CrP4zQjlBQlGeHat+TFivPTkuh1IPyFt184b0uB/RUh9ntgQO6 7SaCeQbtpo6DxKX22vaL1WamYxef4cH91t+06fo96SdS4IzWV6u4ZPZe4c2tMMpjQAuK 5oF1XH5PGppbgY17zkDqxCn6Jjm7Q5P0Tuhbb/QnwO2CSDFf4yiQcUp9ejxjjG0T5pZD TpNlBwPQpgrgOnqdSXkGRaPzlIQ66YTDtPjfylj7mUdGsZyqWqGdlcknyU6ccIfMDH78 HFAp9s1X4fgTss+HEuSuwB6tUv6GVbEEct3avp4O5E4j0g7UydiVq28Wifkfjz8Xv1Dc KNPQ== X-Gm-Message-State: AKGB3mLczrNbmd1XBczh8Iq7dpq4w4bWbJI1g0tIItHMIhp/AXYZjAoq hW7ZTVeXgfdHprC1qb2Z3fDfG9tg3h4649Q3+JE= X-Google-Smtp-Source: AGs4zMY2QUHIRbq6NOM6y6D0kTUGI/peMKW3LgEfS9m5eOLknCBCDgDwokq8jR+LaaSLVPUcDFS+JSf/oaHuiAtIAbo= X-Received: by 10.31.205.131 with SMTP id d125mr1628191vkg.198.1512044210887; Thu, 30 Nov 2017 04:16:50 -0800 (PST) MIME-Version: 1.0 Sender: etnapierala@gmail.com Received: by 10.176.17.211 with HTTP; Thu, 30 Nov 2017 04:16:50 -0800 (PST) In-Reply-To: <20171129030035.W2283@besplex.bde.org> References: <201711281253.vASCrtlB071488@repo.freebsd.org> <20171129030035.W2283@besplex.bde.org> From: Edward Napierala Date: Thu, 30 Nov 2017 12:16:50 +0000 X-Google-Sender-Auth: zl3iv-ICMRnIMx8kAiK972LAef0 Message-ID: Subject: Re: svn commit: r326314 - in head/sys: ddb kern sys To: Bruce Evans Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 12:16:52 -0000 2017-11-28 17:04 GMT+00:00 Bruce Evans : > On Tue, 28 Nov 2017, Edward Tomasz Napierala wrote: > > Log: >> Make kdb_reenter() silent when explicitly called from db_error(). >> This removes the useless backtrace on various ddb(4) user errors. >> >> Reviewed by: jhb@ >> Obtained from: CheriBSD >> MFC after: 2 weeks >> Sponsored by: DARPA, AFRL >> Differential Revision: https://reviews.freebsd.org/D13212 >> > > This doesn't fix the spam for user errors that cause a trap, which are > very common (for mistyping memory addresses). ddb sets up trap handlers > using setjmp, and actually does this correctly in many cases, but when > a trap occurs the error handling is: > > trap -> kdb_reenter (print spam here) -> ddb (print error message here) > Indeed. But, as you said later in that email, some of those messages actually are (or might be) useful. The intent of that change was only to silence down those that certainly are not. Also, differently from silencing them down with a sysctl, this change makes them silent out of the box. Agreed about the style problems; I might (can't promise, though) fix that later.