From owner-svn-src-all@freebsd.org  Fri Jul 10 08:25:49 2020
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id B4A833637C8;
 Fri, 10 Jul 2020 08:25:49 +0000 (UTC)
 (envelope-from pstef@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4B35hs4LQBz4Jq4;
 Fri, 10 Jul 2020 08:25:49 +0000 (UTC)
 (envelope-from pstef@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1403)
 id 8A3E5149E4; Fri, 10 Jul 2020 08:25:49 +0000 (UTC)
Date: Fri, 10 Jul 2020 10:25:49 +0200
From: "Piotr P. Stefaniak" <pstef@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r363068 - head/sys/kern
Message-ID: <20200710082549.GC74062@freefall.freebsd.org>
References: <202007100646.06A6kgnX015296@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <202007100646.06A6kgnX015296@repo.freebsd.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Jul 2020 08:25:49 -0000

> 	 */
>-	memcpy(sbp, &mp->mnt_stat, sizeof(*sbp));
>+	if (sbp != &mp->mnt_stat)
>+		memcpy(sbp, &mp->mnt_stat, sizeof(*sbp));
>

Slightly unrelated question: wouldn't it be prudent to incorporate this
logic into memcpy?