From owner-freebsd-stable@FreeBSD.ORG Tue Nov 25 14:28:31 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B0802106564A; Tue, 25 Nov 2008 14:28:31 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id 55C9D8FC1B; Tue, 25 Nov 2008 14:28:31 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1L4yty-000NEc-7z; Tue, 25 Nov 2008 16:28:30 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id mAPESRPm057720 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 25 Nov 2008 16:28:27 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id mAPESRfh046284; Tue, 25 Nov 2008 16:28:27 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id mAPESRYs046279; Tue, 25 Nov 2008 16:28:27 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 25 Nov 2008 16:28:27 +0200 From: Kostik Belousov To: Josh Carroll Message-ID: <20081125142827.GI2042@deviant.kiev.zoral.com.ua> References: <8cb6106e0811241129o642dcf28re4ae177c8ccbaa25@mail.gmail.com> <20081125140601.GH2042@deviant.kiev.zoral.com.ua> <8cb6106e0811250617q5fffb41exe20dfb8314fc4a9d@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YrQNB5Deg1WGKZi3" Content-Disposition: inline In-Reply-To: <8cb6106e0811250617q5fffb41exe20dfb8314fc4a9d@mail.gmail.com> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.93.3, clamav-milter version 0.93.3 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1L4yty-000NEc-7z a13e4a15a875bcf41a1bab53dbf2c87b X-Terabit: YES Cc: freebsd-fs@freebsd.org, FreeBSD Stable Subject: Re: ext2 inode size patch - RE: PR kern/124621 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2008 14:28:31 -0000 --YrQNB5Deg1WGKZi3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 25, 2008 at 09:17:06AM -0500, Josh Carroll wrote: > > I already expressed my opinion on > > http://lists.freebsd.org/pipermail/freebsd-hackers/2008-September/02593= 3.html > > >=20 > Sorry, I do not subscribe to hackers@ so I did not see that message. > So what do you recommend is done to further test it? I tested simple > things like copies, writes, deletes, etc on a memory disk, but nothing > formal. I don't (currently) have a spare blank disk or space on an > existing disk to test on physical media, but I can look into doing so > once my development box is back up and running. > > I'm also curious what about the changes you feel are dangerous, so > I can target the testing to exercise the boundary conditions or > circumstances you think this patch would elicit problems. I do not suggest testing. I suggest understand what inode metadata is stored in the added 128 bytes and evaluate whether this information can be ignored without dangerous consequences for filesystem consistency or user data. --YrQNB5Deg1WGKZi3 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkksC4sACgkQC3+MBN1Mb4jj1QCfaVNB2QHYcaUXwA/t2L1v96Lr y4gAmwfewF0Ox1PUlLFkRCj8QFLQnVGu =u/UR -----END PGP SIGNATURE----- --YrQNB5Deg1WGKZi3--