Date: Fri, 13 May 2005 14:09:52 +0300 From: Vasil Dimov <vd@datamax.bg> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/80971: fvwm2 overrides PKGNAMESUFFIX set by fvwm2-i18n Message-ID: <20050513110952.GA59444@sinanica.bg.datamax> Resent-Message-ID: <200505131110.j4DBA2dW000796@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 80971
>Category: ports
>Synopsis: fvwm2 overrides PKGNAMESUFFIX set by fvwm2-i18n
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri May 13 11:10:02 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Vasil Dimov
>Release: FreeBSD 5.4-STABLE i386
>Organization:
DataMax
>Environment:
System: FreeBSD sinanica.bg.datamax 5.4-STABLE FreeBSD 5.4-STABLE #6: Tue May 10 12:46:25 EEST 2005 root@sinanica.bg.datamax:/usr/obj/usr/src/sys/SINANICA-SMP i386
>Description:
If imlib is installed on the system (${HAVE_GNOME:Mimlib}!="") then
x11-wm/fvwm2's Makefile sets PKGNAMESUFFIX regardless of its old
value which may have been previously set by x11-wm/fvwm2-i18n.
As a result we get two ports with identical PKGNAME which leads
to incorrect make search results and warnings while INDEX builds.
% make index
...
Warning: Duplicate INDEX entry: fvwm-imlib-2.4.19
>How-To-Repeat:
Make sure graphics/imlib is installed: ${HAVE_GNOME:Mimlib}!=""
needs to be true.
% cd /usr/ports/x11-wm/fvwm2 && make -V PKGNAME
fvwm-imlib-2.4.19
% cd /usr/ports/x11-wm/fvwm2-i18n && make -V PKGNAME
fvwm-imlib-2.4.19
% cd /usr/ports && make index
% cd /usr/ports && make search name=fvwm
(notice the missing port)
>Fix:
I think the following patch should be applied to x11-wm/fvwm2/Makefile
It makes fvwm2-i18n's PKGNAME fvwm2-i18n-imlib-2.4.19
(or fvwm2-i18n-2.4.19 if no imlib is installed)
--- Makefile.patch begins here ---
--- fvwm2/Makefile.orig Fri May 13 13:31:12 2005
+++ fvwm2/Makefile Fri May 13 13:45:08 2005
@@ -60,7 +60,7 @@
.if ${HAVE_GNOME:Mimlib}!=""
USE_GNOME= imlib
-PKGNAMESUFFIX= -imlib
+PKGNAMESUFFIX:= ${PKGNAMESUFFIX}-imlib
CONFIGURE_ARGS+= --with-gnome --enable-gnome-hints \
--enable-gtktest --enable-imlibtest
PLIST_SUB+= GTK=""
--- Makefile.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050513110952.GA59444>