Date: Sun, 01 Sep 2013 08:31:42 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r325807 - in head: . Mk Message-ID: <522341BE.2070201@FreeBSD.org> In-Reply-To: <20130901091427.GA77614@FreeBSD.org> References: <201308311356.r7VDu8N8094811@svn.freebsd.org> <20130831141013.GA27765@FreeBSD.org> <5221FA9D.7020005@FreeBSD.org> <20130901091427.GA77614@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UVPoFT1U0MuaIm7bVVuaw8uuw9k5MeFcK Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 9/1/2013 4:14 AM, Alexey Dokuchaev wrote: > On Sat, Aug 31, 2013 at 09:15:57AM -0500, Bryan Drewery wrote: >> make build-depends USE_PACKAGE_DEPENDS >> This installs dependencies from packages if present, else, fallback = on >> source. >> >> make build-depends USE_PACKAGE_DEPENDS_ONLY >> This installs dependencies from packages only. >=20 > Yes, that's how I understood it. I still fail to see how it can be use= ful > for regular ports users (vs. bulk builders like poudriere or tinderbox)= =2E > Several things are immediately not clear to me: 1) as a ports user, I d= o > not have any binary packages repositories around (except tinderbox cach= e); > 2) even if I would, how can it be decided on per-ports basis what *user= * > wants to use, ports or packages: I don't see the reason to expose this = at > the ports' Makefile level; 3) it looks (even without looking at the det= ails > of implementation) like some sort of hack, and that bothers me. >=20 >> It has nothing to do with misspelling anything. >=20 > I was referring to the cases when wrongly spelled LIB_DEPENDS results i= n > ports rebuilding already-installed-from-package dependencies because, s= ay, > package installs libfoo.so.4, but port says libfoo.so.3 because of miss= ed > shlib version bump. In this case, build log would be polluted with the= > build of the dependency, which normally would not happen (only lines li= ke > "package libfoo-1.42 already installed" and "... depends on libfoo.so.4= - > found" should be there). >=20 >> These are used to install dependencies from packages using the ports >> framework. The alternative is to have the package building tool instal= l >> the dependencies themselves, which tinderbox _and_ portbuild do wrong!= >=20 > Perhaps I don't quite understand this particular point here, but why no= t > fix tinderbox/portbuild instead? Are we talking about some really hard= to > track down and fix bug(s) here? >=20 >> The reason for _ONLY is that if a dependency failed to build, a port >> would still, in some race-condition cases, run build-depends, not find= >> the dependency packages, then try to build them. Having no network >> access, it would hit fetch errors; it shouldn't be building missing >> dependencies, it should immediately fail because dependencies were not= met. >> >> The PR has more information and linked patches which demonstrate the i= ssue: >> >> http://www.bayofrum.net/~crees/scratch/log.log >> >> With fix: >> >> http://www.bayofrum.net/~crees/scratch/loglog.log >=20 > What I see exactly proves my point: these knobs belong inside the bulk > builder, not in the ports' Makefiles. If I would see, as a user, that = I'm > having some network problem, I would rather go and fix it, and continue= > to play with my ports. This obviously may not work for bulk builders, > but that's totally different use case and definitely not something norm= al > ports users should case about or even know =3D see those USE_PACKAGE_DE= PENDS* > knobs. Yes of course. As the log message said, USE_PACKAGE_DEPENDS *did not change*. This *adds a feature* for package building. >=20 > ./danfe >=20 --=20 Regards, Bryan Drewery --UVPoFT1U0MuaIm7bVVuaw8uuw9k5MeFcK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSI0HCAAoJEG54KsA8mwz5miAP/jgdr9hnUJIISKccPkl+B5Bq /AaNfrCfa6atgfhMNrpabZcA+LBmKV8w7dQaYsmJ5QG0puOHhlEyb9237+N+2pHP YKkLU7TchwgxiO2vWIpzG76+RhAprxNi0++wxQ04l0wGM2SwlTsci36qs1YwtDod oaqZoQIN2P/wzunGyO9O3QAuEdyUJvgp/OvOG1CTldj5hESVxmgOMuHHsQIh68VV 79MyQoMtBIL9l066+faDm9cQIoCJEwwNEBBkz40gdXIApMtPIYbEAlSNUn3ByRe9 x+uVDZAWaFg01qsPGaLn3ti1TN2GcVyU7BWxQTeD+PrS4TI0Oxa5N8kePndRgO3q XNtDvumaZFCfUo75XrRyZNv6/C+ST0qB2LZyH/66dRnG7hfvIj87vSZhuZjyEgZ6 9qlMxH0NSS7ElYBF7AXooPbdj+MIvYuBIHNSN1ud6znsks+mA7iw5JsHOYxRm9CQ ebyZIFL9LsNeeO5QJWXACrPEl/pQNRV09rRZL2j47T3kk4eh7Y3o3oAxcj+/Jpf6 WqexVyldXQ0rAq1gpUbpQ2/UEWM7lIKFM12rr4JxmdY7lFOaNQDKVBk54VTQkVn0 yPCIiegV8HquXToxliGSgKnBuSeoJA/mklNv1/Op+/3qOQV5UIATWxLHVQaKUdd6 JQOqYEWq898vFlA31m9r =voHb -----END PGP SIGNATURE----- --UVPoFT1U0MuaIm7bVVuaw8uuw9k5MeFcK--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?522341BE.2070201>