From owner-svn-ports-all@FreeBSD.ORG  Tue Feb  4 14:36:42 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C67F01F4;
 Tue,  4 Feb 2014 14:36:42 +0000 (UTC)
Received: from mail.issp.ac.ru (mail.issp.ac.ru [77.236.34.3])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 453B61410;
 Tue,  4 Feb 2014 14:36:41 +0000 (UTC)
Received: from lqc.issp.ac.ru [77.236.34.156:42710] (HELO/EHLO
 mercury.ph.man.ac.uk, authenticated with LOGIN)
 by mail.issp.ac.ru with ESMTP/inet id s14EacpQ091686 (using TLSv1/SSLv3,
 with cipher DHE-RSA-AES256-SHA (256 bits), verified NO)
 Tue, 4 Feb 2014 18:36:39 +0400 (MSK)
From: Max Brazhnikov <makc@freebsd.org>
To: Mathieu Arnold <mat@freebsd.org>
Subject: Re: svn commit: r342510 - head/games/cutemaze
Date: Tue, 04 Feb 2014 14:36:38 +0000
Message-ID: <3033718.ko1yqU3EN4@mercury.ph.man.ac.uk>
User-Agent: KMail/4.10.5 (FreeBSD/9.2-STABLE; KDE/4.10.5; amd64; ; )
In-Reply-To: <0490893710F9E2B81364BC6A@ogg.in.absolight.net>
References: <201402041149.s14BnPX0031911@svn.freebsd.org>
 <7999310.FuPfOJuxd6@mercury.ph.man.ac.uk>
 <0490893710F9E2B81364BC6A@ogg.in.absolight.net>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Cc: svn-ports-head@freebsd.org, Rusmir Dusko <nemysis@freebsd.org>,
 svn-ports-all@freebsd.org, ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Feb 2014 14:36:42 -0000

On Tue, 04 Feb 2014 14:37:07 +0100 Mathieu Arnold wrote:
> +--On 4 f=C3=A9vrier 2014 13:05:39 +0000 Max Brazhnikov <makc@freebsd=
.org>
> wrote:
> |=20
> | This part should be reverted.
> | Folks, please *review* what makeplist generates and don't commit it=

> | blindly.
>=20
> I for one would love to have feedback on what the evolved makeplist s=
hould
> do better :-)

It's way too aggressive for PLIST_SUB and this leads to false substitut=
ions=20
sometimes. bsd.qt.mk defines a number of QT_*DIR, but not all of them s=
hould=20
be used (actually it depends on particular port).
We could help makeplist by telling explicitly which substitutions are r=
ight,
e.g. by specifying OPTIONS_SUB.

Max