From owner-svn-ports-all@FreeBSD.ORG  Wed Apr  8 23:21:52 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 73DD61B4;
 Wed,  8 Apr 2015 23:21:52 +0000 (UTC)
Received: from vps.amdmi3.ru (vps.amdmi3.ru [109.234.38.216])
 by mx1.freebsd.org (Postfix) with ESMTP id 37A9AA5A;
 Wed,  8 Apr 2015 23:21:51 +0000 (UTC)
Received: from hive.panopticon (unknown [213.148.20.85])
 by vps.amdmi3.ru (Postfix) with ESMTPS id 9D506B0623;
 Thu,  9 Apr 2015 02:21:49 +0300 (MSK)
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
 by hive.panopticon (Postfix) with ESMTP id 8F21883C;
 Thu,  9 Apr 2015 02:21:42 +0300 (MSK)
Received: by hades.panopticon (Postfix, from userid 1000)
 id D95D030F3; Thu,  9 Apr 2015 02:21:44 +0300 (MSK)
Date: Thu, 9 Apr 2015 02:21:44 +0300
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: Bryan Drewery <bdrewery@FreeBSD.org>
Subject: Re: svn commit: r383191 - head/Mk
Message-ID: <20150408232144.GX21982@hades.panopticon>
References: <201504040535.t345ZJ9M028396@svn.freebsd.org>
 <20150408194202.GA45809@hades.panopticon>
 <5525A9C1.5010003@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <5525A9C1.5010003@FreeBSD.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Apr 2015 23:21:52 -0000

* Bryan Drewery (bdrewery@FreeBSD.org) wrote:

> >>   Re-enable and rework check added in r370464 to validate the first CATEGORY
> >>   is set properly.  The problem causing the revert in r370475 was fixed in
> >>   r383190.
> >>   
> >>   With hat:	portmgr
> > 
> > This breaks countless usecases when port is build which does not belong
> > to the ports tree.
> 
> Please name even 1 case.

I have a lot of WIP ports in flat directory. Tons of custom port
repositories on github with flat structure.

> Building a port with the wrong first CATEGORY results in a broken
> package as the origin is wrong.

I'm not talking about wrong categories, I'm talking about ports outside
of the ports tree. These should build perfectly fine.

> > Afaik, we have that information in ports - based on
> > that PORTSDIR is chosen. The same mechanism should be used here to
> > conditionally enable the check.
> 
> That made no sense.

Explain.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru      http://amdmi3.ru