From nobody Sat Feb 3 05:24:27 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TRh0J2Hwlz58M4M; Sat, 3 Feb 2024 05:24:32 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TRh0J1hnGz43Pd; Sat, 3 Feb 2024 05:24:32 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706937872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N/4ug4wiPRJfYv3mBUfV5IpUfhgaASQPbd0sBSLsuGY=; b=T7S4Sr5BELCGTu3JhD17YeVFbDmZko0GY4DAbHEXxHdyyvhBvsXbwlguk8xxIMSaXkp06f JMIHP9A6W/RgF7u7vzxS94CgYjIMgWi+8vGCgEAPomxKD18hzj6jE5/q62SsfYemMiSh4C snBi8hShNd/j43jPwIjgAmuhD03sFmIC/sJpWfVU8CNhVaMwLvDx9NYMtPEqYxEbu+2zxR A8ad6XkX9TZUEyAJ5uQ3JQ8hzyCGqN3hMv3pOwuZS268fmkD7kyuJSqqzZvoZ6Gtt3WW9F tQ8hImqND0lZJkOykQcudXBa6TUpcM0P6pRpGfUtoi2s3glD7vlX3JUcMI7F8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706937872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N/4ug4wiPRJfYv3mBUfV5IpUfhgaASQPbd0sBSLsuGY=; b=Yz3fXsZ9Vf4EXfbehC7AgYkdo4GcsUpQgS444fqGIItOXFnBPlKvydFko6KhYcY1wun2py gQRdTMdRSiTlbs+kRtWiIqVPy56jtEK13kINdrYa0Mi5NNvMkO8K/Gm2HORmfbZ3hwsFrC nSnIZzR8JTV0ZnUIGcfe3bYkUILTxXojU42+nbYOAIWQ5wyy0QEEBR+ClYmJTrWCFMTuDu fLTTAvUcKDDk+ofawhQt3CpAPlhRbliX7d1IQxlwJ+RgTHjuD9oBMa1RgpbQinaB2Wyx6E RqoHuRi6FOoyaXq6oXyBnydidFzvexDZgWuENVkrR9AWwIsErFApkrbDdt2KAg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706937872; a=rsa-sha256; cv=none; b=PrJheYPJzbm7BECOOLxj3Z8ZZo2bzUW/3JX5bVPooFxbkSNkHkFoKWD4acK061StwKbGmV mo1xTZ2TXsLdSaloJRxRDDcv/+paJGVEYYnQvDnwy3Y2vaHApWMbR4Oa1ZxTVxnxxaY5F6 zPj0IhObS/LKvuet0ehLU0/rX6gSGDuTep+rFDKOew/oCWKiFEIrjcZT8rI1GXYCsSrNeF X37JYeRfiuXeyathCbT8ptmOG7bgernCTYihrlBFLQ2/wh+HxQWOetyc9C9RSdhvMM0g+u Zm8ZuFy0e3fZLR3HHPyNziZjPt2Wodc/txl+czHG6tEKf/anauR4IRnicxDCMQ== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TRh0H1jyPz17cm; Sat, 3 Feb 2024 05:24:31 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Fri, 2 Feb 2024 21:24:27 -0800 From: Gleb Smirnoff To: Mina =?utf-8?B?R2FsacSH?= Cc: Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: ce348fe5cfc3 - main - amd64 & i386: enable VIMAGE in MINIMAL Message-ID: References: <202402030136.4131aQIM010980@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <202402030136.4131aQIM010980@gitrepo.freebsd.org> Mina, On Sat, Feb 03, 2024 at 01:36:26AM +0000, Warner Losh wrote: W> commit ce348fe5cfc36c454db860f0e5cd26f094deb09c W> Author: Mina Galić W> AuthorDate: 2024-02-03 00:35:18 +0000 W> Commit: Warner Losh W> CommitDate: 2024-02-03 01:35:00 +0000 W> W> amd64 & i386: enable VIMAGE in MINIMAL W> W> VNET(9) is very useful, and is not loadable. W> Enable it in MINIMAL. W> W> Reviewed by: imp W> Pull Request: https://github.com/freebsd/freebsd-src/pull/962 To be fair, it totally disagree with this change. The TL;DR version of my comment would be: if you start adding everything very useful into MINIMAL it stops being minimal. A longer version would be that VIMAGE actually allocates extra memory and adds a bit of extra CPU cycles. Even its introduction to GENERIC was met with a lot of criticism, check out the archives. Back then I asked if anybody is going to provide gdb scripts to deal with complexity of access to all global network variables. Nobody provided them of course. Now dealing with every network stack bug report is a challenge. Raise your hands those who can print me out list of interfaces in kgdb for a VIMAGE kernel! Anybody? Good, now keep your hand up if you can do that without spening some time reading vnet.h! I don't doubt usefulness of VIMAGE but I will also assert usefullness of a supported kernel configuration without VIMAGE. There are many people who intentionally run without it in production. Now if I build all kernels in sys/amd64/conf I want even notice that non-VIMAGE build had been broken. Such changes, I believe, should go through phabricator, where you would put #network into reviewers, not via github. -- Gleb Smirnoff