From nobody Thu Sep 18 08:51:55 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cS8Wv3Fh7z681fj; Thu, 18 Sep 2025 08:51:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cS8Wv2mqCz3hng; Thu, 18 Sep 2025 08:51:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758185515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QoRaSZ3lrpj0Clu2UK95Vug5AWBkF4X6dyeeFMboAi0=; b=ZCiiAPcvpMGup2PMYnO43qU97MkMitSfcWpEnRMCZSrStj8ESfGx+iLlsxXRrVcEpUs+KA E/zWq3dgO2vW2IjQBNwA5AjgOkTivsYqlSAaH3/ghDdNenzb09muqvCWNQMxrSBpdcVPYE qYqTNhYbdUnSV6uzHaYRTigKxCr2FXAmr5wMuBexKnTQxMzHNAzRXy+/9NXT6XPBrJTIEB wgJetyt6F8WkFMWRN4K+P9mvwHX2kRCisa/MQZpXXEhr9Lar+RvyblumjGviWe0UAKR9Pi 3TbWx65ilg2tRPxMc+2+UEf3iogogE94rXvsutbZ8qfzAQ3F6UmErrmWgbs9Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758185515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QoRaSZ3lrpj0Clu2UK95Vug5AWBkF4X6dyeeFMboAi0=; b=yW92uqqRIUfsYVUWcp9vC6clUexOlk1hwP1Ryc2dXXnfZxNBxneZmr2nOfewTHo9DmEoGQ cASEXGh0T23gR8OqFWa4UPhgcdG6FL/j5OrEmonrwmDqBobOeuTtxfFZ52OC95sRjaB+p/ I5Nd++hCwQuBDhDQCf9Dj1p0S48ggRskhylr88qGLuFpUBKNerRGj6nvfYNaof0cpPozTF cKuvVuYcGhXlPlSytbkE9qtqGIiKBlI8NpzWbRnISOJlxb5a0Jw2NGNdZS0kFnvboVY9Aa JrmWihshTBEbJJj4ocbHWIS9oscsdVR5Z5dJgtkiwSNZRsP1zYMOjDkttRB5Dg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758185515; a=rsa-sha256; cv=none; b=vzTOfKGByPV4V7lQZuB5nay8OsSBT8J3OW7hOMUxEhbCOp8C9g30wc0DKl0PgEhOEBn9KD /Edw5sdzwU60hr1HRJN58yHGnScbFDfXCUQCZbXsmHqvRA9MFVrHawpIMyabr2AjSyms/Z Ho/9fFUhOVWR7Af3TZOtn70K4T4TstdcuHxn58eDDNs4A6lzafiMyhtC4kjbbCRRI3Ub+E x2i7I9SYle0sjKviHf6vFob0jffSb7880eyiii4c9qhRph2p2bk8+lubDbNagBlo3euJjM Z6t3NOdk/GULOY4T92a1+zH6D22NiEQJvJHWyiRYXTlRW5baFTxG0jZr3yRwzQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cS8Wv2D0fz147l; Thu, 18 Sep 2025 08:51:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58I8pt36017254; Thu, 18 Sep 2025 08:51:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58I8ptMG017251; Thu, 18 Sep 2025 08:51:55 GMT (envelope-from git) Date: Thu, 18 Sep 2025 08:51:55 GMT Message-Id: <202509180851.58I8ptMG017251@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 960dbe036d85 - stable/15 - ddb ps: Print again the effective GID, separately List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 960dbe036d853dee08f3d5220c970bb6964baf2f Auto-Submitted: auto-generated The branch stable/15 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=960dbe036d853dee08f3d5220c970bb6964baf2f commit 960dbe036d853dee08f3d5220c970bb6964baf2f Author: Olivier Certner AuthorDate: 2025-08-26 08:56:54 +0000 Commit: Olivier Certner CommitDate: 2025-09-18 08:50:22 +0000 ddb ps: Print again the effective GID, separately Following commit be1f7435ef218b1d ("kern: start tracking cr_gid outside of cr_groups[]"), cr_groups[] doesn't contain the effective GID anymore. Fix the 'show proc' DDB command to show it again, and make it stand out with respect to the supplementary ones. Fixes: be1f7435ef218b1d ("kern: start tracking cr_gid outside of cr_groups[]") MFC after: 9 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D52251 (cherry picked from commit de974a0f1b73e79466c25f3c85fe727004576fea) --- sys/ddb/db_ps.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/sys/ddb/db_ps.c b/sys/ddb/db_ps.c index 733c440f5ee3..a26cf8161294 100644 --- a/sys/ddb/db_ps.c +++ b/sys/ddb/db_ps.c @@ -459,12 +459,11 @@ DB_SHOW_COMMAND(proc, db_show_proc) db_printf("??? (%#x)\n", p->p_state); } if (p->p_ucred != NULL) { - db_printf(" uid: %d gids: ", p->p_ucred->cr_uid); - for (i = 0; i < p->p_ucred->cr_ngroups; i++) { - db_printf("%d", p->p_ucred->cr_groups[i]); - if (i < (p->p_ucred->cr_ngroups - 1)) - db_printf(", "); - } + db_printf(" uid: %d gid: %d supp gids: ", + p->p_ucred->cr_uid, p->p_ucred->cr_gid); + for (i = 0; i < p->p_ucred->cr_ngroups; i++) + db_printf(i == 0 ? "%d" : ", %d", + p->p_ucred->cr_groups[i]); db_printf("\n"); } if (p->p_pptr != NULL)