From owner-cvs-ports@FreeBSD.ORG  Tue Aug  5 05:04:33 2008
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 830F81065679; Tue,  5 Aug 2008 05:04:33 +0000 (UTC)
Date: Tue, 5 Aug 2008 05:04:33 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Martin Wilke <miwi@FreeBSD.org>
Message-ID: <20080805050433.GA31566@FreeBSD.org>
References: <200808042330.m74NUd9C071984@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <200808042330.m74NUd9C071984@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/Mk bsd.qt.mk ports/devel Makefile
	ports/multimedia Makefile ports/textproc Makefile ports/www
	Makefile ports/accessibility/qt4-accessible Makefile distinfo
	ports/chinese/qt4-codecs-cn Makefile distinfo pkg-plist ...
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Aug 2008 05:04:33 -0000

On Mon, Aug 04, 2008 at 11:30:39PM +0000, Martin Wilke wrote:
>   Log:
>   - Update to qt 4.4.1

Hi Martin,

I haven're reviewed each and every change (it's obviously too much of
them ;-) but at least ports/x11/qt4-opengl/Makefile looks strange: it
seems you somehow restored USE_GL=yes and USE_XLIB=yes instead of
fine-grained values like glu for GL and specific XORG compoments?  Is it
intentional?

You could have also just removed PORTREVISION line instead of reseting
it to zero.

Thanks.  I will answer your previous mail shortly.

./danfe