From owner-svn-src-all@FreeBSD.ORG Sun Feb 7 19:41:32 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EE05A106566C for ; Sun, 7 Feb 2010 19:41:31 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 300C88FC16 for ; Sun, 7 Feb 2010 19:41:29 +0000 (UTC) Received: (qmail 4306 invoked by uid 399); 7 Feb 2010 19:41:29 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 7 Feb 2010 19:41:29 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4B6F1778.4020703@FreeBSD.org> Date: Sun, 07 Feb 2010 11:41:44 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.7) Gecko/20100123 Thunderbird/3.0.1 MIME-Version: 1.0 To: Bruce Simpson References: <201002062122.o16LM1eS042778@svn.freebsd.org> <4B6E43C0.3060302@FreeBSD.org> <4B6E47CA.7020506@incunabulum.net> In-Reply-To: <4B6E47CA.7020506@incunabulum.net> X-Enigmail-Version: 1.0 OpenPGP: id=D5B2F0FB Content-Type: multipart/mixed; boundary="------------070105070009020101050600" Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Bruce M Simpson Subject: Re: svn commit: r203574 - head/etc X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Feb 2010 19:41:32 -0000 This is a multi-part message in MIME format. --------------070105070009020101050600 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/06/10 20:55, Bruce Simpson wrote: > On 07/02/2010 04:38, Doug Barton wrote: >> >> Are all the port numbers that have been added recently things that >> have been requested by users? IIUC there is a cost "albeit small" for >> parsing the /etc/services file each time it's read, so traditionally >> we've tried to keep it as small as possible while still meeting the >> needs of our users. > > I've been running sane-backends with this mod locally on all my FreeBSD > desktop clients for some time. Given that it's been given an official > allocation by IANA it seemed reasonable to add it to our own > /etc/services to support this use. It's pretty essential for day-to-day > office use of FreeBSD as a desktop system. I'm taking from your message that you have a defined, limited goal in mind for adding certain ports, which I have no objection to. After all, developers are users too. :) > I have a diff to add an RC script to the existing graphics/sane-backends > port here, Ok, a couple of comments. Overall it looks good. Although it's not critical you can s#%%RC_SUBR%%#/etc/rc.subr#. The first "saned_uid=saned" line is not needed, your default variable assignment is fine. However the default empty variable assignment for _flags is not necessary or desirable. It's better to put that information in the comments. See http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html for examples. There are a few other issues, like not doing the _flags warning unconditionally, etc. The attached version should work for you, test it of course, caveat emptor, one per person, etc. hth, Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ Computers are useless. They can only give you answers. -- Pablo Picasso --------------070105070009020101050600 Content-Type: text/plain; name="saned.in" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="saned.in" IyEvYmluL3NoCiMKIyAkRnJlZUJTRCQKIwojIFBST1ZJREU6IHNhbmVkCiMgUkVRVUlSRTog bmV0aWYgcm91dGluZyBtb3VudGNyaXRsb2NhbAojIEJFRk9SRTogIE5FVFdPUktJTkcKIwoj IEEgc2FtcGxlIHNhbmVkIHN0YXJ0dXAgc2NyaXB0LgojCiMgQWRkIHRoZSBmb2xsb3dpbmcg bGluZSB0byAvZXRjL3JjLmNvbmYgdG8gZW5hYmxlIHNhbmVkOgojCXNhbmVkX2VuYWJsZT0i WUVTIgojCiMgQkxBSCBCTEFIIEJMQUggQkxBSCBCTEFIIEJMQUggQkxBSAojCXNhbmVkX2Zs YWdzPSIiCiMKCi4gL2V0Yy9yYy5zdWJyCgpuYW1lPSJzYW5lZCIKcmN2YXI9YHNldF9yY3Zh cmAKY29tbWFuZD0iJSVQUkVGSVglJS9zYmluLyR7bmFtZX0iCgpzdGFydF9wcmVjbWQ9JHtu YW1lfV9wcmVzdGFydAoKc2FuZWRfcHJlc3RhcnQoKQp7CgljYXNlICIke3NhbmVkX2ZsYWdz fSIgaW4KCSotYVwgKikgZXJyICJzYW5lZF9mbGFncyBpbmNsdWRlcyB0aGUgLWEgb3B0aW9u LiBQbGVhc2UgdXNlIHNhbmVkX3VpZCBpbnN0ZWFkLiIgOzsKCWVzYWMKfQoKbG9hZF9yY19j b25maWcgJG5hbWUKCjogJHtzYW5lZF9lbmFibGU9Ik5PIn0KOiAke3NhbmVkX3VpZD0ic2Fu ZWQifQoKY29tbWFuZF9hcmdzPSItYSAkc2FuZWRfdWlkIgoKcnVuX3JjX2NvbW1hbmQgIiQx IgoK --------------070105070009020101050600--