From owner-cvs-all@FreeBSD.ORG Thu Jul 15 17:35:25 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8F6EB16A4CE; Thu, 15 Jul 2004 17:35:25 +0000 (GMT) Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4204443D45; Thu, 15 Jul 2004 17:35:25 +0000 (GMT) (envelope-from pjd@darkness.comp.waw.pl) Received: by darkness.comp.waw.pl (Postfix, from userid 1009) id 17F1CACAEE; Thu, 15 Jul 2004 19:35:24 +0200 (CEST) Date: Thu, 15 Jul 2004 19:35:24 +0200 From: Pawel Jakub Dawidek To: Robert Watson Message-ID: <20040715173524.GG12007@darkness.comp.waw.pl> References: <20040715170320.GF12007@darkness.comp.waw.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rXoc3kw+CNDOk2Sr" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 5.2.1-RC2 i386 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: "Christian S.J. Peron" cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_descrip.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jul 2004 17:35:25 -0000 --rXoc3kw+CNDOk2Sr Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 15, 2004 at 01:21:09PM -0400, Robert Watson wrote: +> > Could we change 'td->td_ucred->cr_ruid !=3D 0 || jailed(td->td_ucred)'= to +> > 'suser(td) !=3D 0'? +>=20 +> No, because suser(td) checks the effective uid, not the real uid. Which +> is the reason I asked him to change it to that before committing, and why +> Colin had to back out his commit also :-). Colin is preparing patches to +> add a flag to suser_cred() to allow the caller to say they care about the +> real uid.=20 Thanks for clarification, but why actually do we care so much here about real uid? --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --rXoc3kw+CNDOk2Sr Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFA9sBcForvXbEpPzQRAglrAJ9uV74GBh98Oy9x81T4lraDi2gXWwCcDHIz +dXA1ejgshnxabDbX51w6xs= =Jf0J -----END PGP SIGNATURE----- --rXoc3kw+CNDOk2Sr--