From owner-svn-src-all@freebsd.org Thu Dec 8 04:44:29 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1A484C6C55B for ; Thu, 8 Dec 2016 04:44:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x243.google.com (mail-io0-x243.google.com [IPv6:2607:f8b0:4001:c06::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D31A814D for ; Thu, 8 Dec 2016 04:44:28 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x243.google.com with SMTP id j92so1101316ioi.0 for ; Wed, 07 Dec 2016 20:44:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=G1vs7L7g9JSy+AVB+33RPb5t4+qI13el6GwsxLq6COA=; b=qD4SH803xcFf1cf3jkDDHQUqtXvApOcVVvG8mXn3TBrArnfiJZiMfUWkQgtT2/HDOz g2XwIltkqpt2GPJJ+OUTJ4/T+Hx7UJCeav3BmP6fyFKoir+eJUkfIZHfabKOQx5YbJhF iXd0Zd30TQg6jZAH19YcQdc0PXGpPB0VENnotdC7qe5fqgfqVdpTJpRF23Mml09qjXSJ 9rCfyaMK8A0StiVFe2G3P94qOw0lgOtwJ5axpU9e31yYUuA9Wu5V2PxYB6ydulYkWjTC IFtrM15ark9GGmJ6UzZEfI5ojRW6tnHuPWJo7u/X0LlqOaA81n5zUSmzat7ET2gDvhF7 T6CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=G1vs7L7g9JSy+AVB+33RPb5t4+qI13el6GwsxLq6COA=; b=DvgbaCQTpi+Ysi3wI1vdm/C7FD/7ZjDFYQz0Tg863OOLEgxZKGZ+LTMj7s6IUsy5lq FGE24bSrAtukDyAxOq6ykqPsDJOQRz9MnAeYH2Xi8VXH9/fTgYZpNxBWlmclM7MrH1hL Xe2iWGmVQt6lbErydOtRpqyl+QU1caJqt8kJhh0loULlcYg8iMjeyy5vhuB/1X2kI4xa n2eNIxldpuHOlbpEmQa3gW8fdLkw6qkNxf3MESBVPG0f5r/oUtFXFqLcbqBonynqB9Rh oX1u5Qyt2ay9vdOePZ9lO4jEaGlnPgQILSQpyegZdCfvq0zKuw34PnlYmKIuxDiGt+i1 M3ug== X-Gm-Message-State: AKaTC0014V4Yj8g95cPZvifI4dK1JEk+PnnJd5e8NbyFh04pZ45I/phjm8sJ6HWiJKZx8o6tjoJsgBUVW7GGiA== X-Received: by 10.107.132.74 with SMTP id g71mr63047634iod.19.1481172268212; Wed, 07 Dec 2016 20:44:28 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.31.199 with HTTP; Wed, 7 Dec 2016 20:44:27 -0800 (PST) X-Originating-IP: [50.253.99.174] In-Reply-To: <20161208033621.GS27748@FreeBSD.org> References: <201612062252.uB6Mqjhr019191@repo.freebsd.org> <20161207212647.GO27748@FreeBSD.org> <20161208123844.B935@besplex.bde.org> <20161208033621.GS27748@FreeBSD.org> From: Warner Losh Date: Wed, 7 Dec 2016 21:44:27 -0700 X-Google-Sender-Auth: vJN-m8MZ0sPn7E2BvQ9t09KA5zk Message-ID: Subject: Re: svn commit: r309658 - head/sys/vm To: Gleb Smirnoff Cc: Bruce Evans , Mark Johnston , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Dec 2016 04:44:29 -0000 On Wed, Dec 7, 2016 at 8:36 PM, Gleb Smirnoff wrote: > On Thu, Dec 08, 2016 at 01:07:06PM +1100, Bruce Evans wrote: > B> >> M> +#ifndef BURN_BRIDGES > B> >> M> +/* > B> >> M> + * Provide compatibility sysctls for the benefit of old utilities which exit > B> >> M> + * with an error if they cannot be found. > B> >> M> + */ > B> >> M> +SYSCTL_UINT(_vm_stats_vm, OID_AUTO, v_cache_count, CTLFLAG_RD, > B> >> M> + (u_int *)NULL, 0, "Dummy for compatibility"); > B> >> M> +SYSCTL_UINT(_vm_stats_vm, OID_AUTO, v_tcached, CTLFLAG_RD, > B> >> M> + (u_int *)NULL, 0, "Dummy for compatibility"); > B> >> M> +#endif > B> >> > B> >> IMHO, there should be some garbage collecting timeout for them. I'd suggest to > B> >> delete them from head after stable/12 branch is forked. > B> > > B> > Other places define #if BURN_BRUDGES < 1200000 to make this automatic. > B> > B> The correct ifdef is something like '#if COMPAT_FREEBSD12' to make this > B> non-automatic. Support for this option should of course be removed some > B> time after the support for COMPAT_43 option. That is only 25-30 years old. > > By the way, can anyone explain me why do we still have COMPAT_43 option? > > I also bet $100 against $10 that it is broken in head in many aspects, > since there is no regression suite for it and since nobody uses it. I'd say that we don't know what is or isn't used if it's working. We only know it isn't working if it fails in a spectacular way for a popular program (cf sbrk and emacs). I'd also say those are about the odds I'd give for all the rest. Warner