From owner-freebsd-ports-bugs@freebsd.org  Mon Aug  1 01:02:51 2016
Return-Path: <owner-freebsd-ports-bugs@freebsd.org>
Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1B4ECBA8E23
 for <freebsd-ports-bugs@mailman.ysv.freebsd.org>;
 Mon,  1 Aug 2016 01:02:51 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 0A8FA15AD
 for <freebsd-ports-bugs@FreeBSD.org>; Mon,  1 Aug 2016 01:02:51 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u7112o7h015966
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 1 Aug 2016 01:02:50 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 211305] devel/gdb: (CORE_ADDR) 0 missing * in cast in
 tui/tui-stack.c
Date: Mon, 01 Aug 2016 01:02:51 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: markmi@dsl-only.net
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Flags: maintainer-feedback+
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-211305-13-UHfsrF8NTZ@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-211305-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-211305-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Aug 2016 01:02:51 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211305

--- Comment #8 from Mark Millard <markmi@dsl-only.net> ---
(In reply to Mark Millard from comment #5)

For:

ada-lang.c:2489:50: warning: shifting a negative signed value is undefined
[-Wshift-negative-value]
          unpacked[unpacked_idx] =3D accum & ~(~0L << HOST_CHAR_BIT);
                                             ~~~ ^
ada-lang.c:2503:46: warning: shifting a negative signed value is undefined
[-Wshift-negative-value]
      unpacked[unpacked_idx] =3D accum & ~(~0L << HOST_CHAR_BIT);
                                         ~~~ ^

there is ( common/common-types.h ):

#ifdef GDBSERVER

/* * A byte from the program being debugged.  */
typedef unsigned char gdb_byte;

. . .

#else /* GDBSERVER */

#include "bfd.h"

/* * A byte from the program being debugged.  */
typedef bfd_byte gdb_byte;
. . .

and there is locally in ada-lang.c

  unsigned long accum;

So it appears to me that UL instead of L covers silencing this in a correct
manor, something like (used twice):

unpacked[unpacked_idx] =3D accum & ~(~0UL << HOST_CHAR_BIT);

--=20
You are receiving this mail because:
You are the assignee for the bug.=