Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 3 May 2015 08:17:37 +0000 (UTC)
From:      Navdeep Parhar <np@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r282365 - stable/10/sys/dev/cxgbe
Message-ID:  <201505030817.t438Hbbf027294@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: np
Date: Sun May  3 08:17:37 2015
New Revision: 282365
URL: https://svnweb.freebsd.org/changeset/base/282365

Log:
  MFC r272051:
  
  cxgbe(4):  Verify that the addresses in if_multiaddrs really are multicast
  addresses.  (The chip doesn't really care, it's just that it needs to be
  told explicitly if unicast DMACs are checked for "hits" in the hash that
  is used after the TCAM entries are all used up).

Modified:
  stable/10/sys/dev/cxgbe/t4_main.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/dev/cxgbe/t4_main.c
==============================================================================
--- stable/10/sys/dev/cxgbe/t4_main.c	Sun May  3 07:43:58 2015	(r282364)
+++ stable/10/sys/dev/cxgbe/t4_main.c	Sun May  3 08:17:37 2015	(r282365)
@@ -2994,8 +2994,10 @@ update_mac_settings(struct ifnet *ifp, i
 		TAILQ_FOREACH(ifma, &ifp->if_multiaddrs, ifma_link) {
 			if (ifma->ifma_addr->sa_family != AF_LINK)
 				continue;
-			mcaddr[i++] =
+			mcaddr[i] =
 			    LLADDR((struct sockaddr_dl *)ifma->ifma_addr);
+			MPASS(ETHER_IS_MULTICAST(mcaddr[i]));
+			i++;
 
 			if (i == FW_MAC_EXACT_CHUNK) {
 				rc = t4_alloc_mac_filt(sc, sc->mbox, viid, del,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201505030817.t438Hbbf027294>