From owner-svn-src-all@freebsd.org Fri Mar 29 14:24:21 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3AA31156AA3F; Fri, 29 Mar 2019 14:24:21 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CD0D595834; Fri, 29 Mar 2019 14:24:20 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-ua1-f45.google.com (mail-ua1-f45.google.com [209.85.222.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 985C22EFD7; Fri, 29 Mar 2019 14:24:20 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-ua1-f45.google.com with SMTP id v7so714763uak.13; Fri, 29 Mar 2019 07:24:20 -0700 (PDT) X-Gm-Message-State: APjAAAVdtecki3VpunvAcbTxifx+YUPCkALFr6Yiz+VnQmyRiR4lxcgm xOx2T0v2xTOxWcQcPabCUYoa6M/D/5UvlPYhWH0= X-Google-Smtp-Source: APXvYqwH2mnjNW3IfZz9nnYUt565QJbfGyBz3Rm2k1be3zNr01Tcx7ub5ic2GGDE34JLiMAIODZH5RFSCk75QDk1D2o= X-Received: by 2002:ab0:20c1:: with SMTP id z1mr14734644ual.109.1553869460098; Fri, 29 Mar 2019 07:24:20 -0700 (PDT) MIME-Version: 1.0 References: <201903290534.x2T5Y7v2097332@gndrsh.dnsmgr.net> In-Reply-To: <201903290534.x2T5Y7v2097332@gndrsh.dnsmgr.net> From: Kyle Evans Date: Fri, 29 Mar 2019 09:24:02 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r345680 - head/sys/conf To: "Rodney W. Grimes" Cc: Ravi Pokala , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: CD0D595834 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.991,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Mar 2019 14:24:21 -0000 On Fri, Mar 29, 2019 at 12:34 AM Rodney W. Grimes wrote: > > > -----Original Message----- > > From: on behalf of Kyle Evans > > Date: 2019-03-28, Thursday at 21:00 > > To: , , > > Subject: svn commit: r345680 - head/sys/conf > > > > > Author: kevans > > > Date: Fri Mar 29 04:00:46 2019 > > > New Revision: 345680 > > > URL: https://svnweb.freebsd.org/changeset/base/345680 > > > > > > Log: > > > NOTES: Use non-default value for BOOT_TAG > > > > Why? > > > > (I was on IRC when jhb debugged this, but I didn't quite get it; and of course lots of us *weren't* on IRC at the time.) > > Yes, please, why is this beeing changed, do I need to revise my .sh that > was hunting for the old string to use what now? Or do I need to now > override this in my KERNCONF files? > > I think changing this in stable/12 is a POLA issue. > > > Thanks, > > > > Ravi (rpokala@) > > > > > Reported by: jhb > > > MFC after: 1 week (except non-empty value in stable/11) > > Why is 11 being treated special, or is it that it does not implement > BOOT_TAG at all? > > Does this deserve a RELNOTES Y, or UPDATING entry? > The short answer to all of this is "No, no, no" -- see Bruce's response about the purpose of NOTES, and the NOTES header itself. It's the kitchen sink, and you can't/won't/don't include the kitchen sink when you need a pipelet. 11 is special because BOOT_TAG was implemented after stable/11 branched. I MFC'd it because I used it on stable/11, but the MFC had to result in a no-op to the msgbuf to not violate POLA.