From owner-freebsd-fs@FreeBSD.ORG Fri Nov 21 23:11:32 2014 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7A87C7BE; Fri, 21 Nov 2014 23:11:32 +0000 (UTC) Received: from esa-jnhn.mail.uoguelph.ca (esa-jnhn.mail.uoguelph.ca [131.104.91.44]) by mx1.freebsd.org (Postfix) with ESMTP id 1DDC7B31; Fri, 21 Nov 2014 23:11:31 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtQEAB/Gb1SDaFve/2dsb2JhbABcg2NZBIMCyQsKhhZVAoEdAQEBAQF9hAMBAQQBAQEgKyALGxgCAg0ZAikBCSYGCAcEARwEiCANtm+XFAEBAQEBAQEBAgEBAQEBAQEBGoEtjw0BARs0B4J5gVUFjCSLJYQlhEA/izCCL4dBhBsqMAeBCDmBAwEBAQ X-IronPort-AV: E=Sophos;i="5.07,433,1413259200"; d="scan'208";a="170199629" Received: from muskoka.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.222]) by esa-jnhn.mail.uoguelph.ca with ESMTP; 21 Nov 2014 18:11:30 -0500 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id 414ACB3F43; Fri, 21 Nov 2014 18:11:30 -0500 (EST) Date: Fri, 21 Nov 2014 18:11:30 -0500 (EST) From: Rick Macklem To: Gleb Kurtsou Message-ID: <960332478.5203628.1416611490254.JavaMail.root@uoguelph.ca> In-Reply-To: <20141121182219.GA1076@reks> Subject: Re: RFC: patch to make d_fileno 64bits MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [172.17.91.203] X-Mailer: Zimbra 7.2.6_GA_2926 (ZimbraWebClient - FF3.0 (Win)/7.2.6_GA_2926) Cc: freebsd-fs@freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Nov 2014 23:11:32 -0000 Gleb Kurtsou wrote: > On (21/11/2014 10:25), John Baldwin wrote: > > On Thursday, November 20, 2014 10:19:14 PM Rick Macklem wrote: > > > The attached patch covers the basics of a way to > > > convert the d_fileno field of "struct dirent" to > > > 64bits. This patch is incomplete and won't even > > > build, but I thought I'd post it in case anyone > > > wanted to take a look and comment on the approach > > > it uses. > > > > > > - renames the old/current one "struct dirent32" > > > - changes d_fileno to 64bits and adds a 64bit > > > d_off field for the offset of the underlying > > > file system > > > - defines a new VOP_READDIR() that will return > > > the new "struct dirent" that is used as the > > > default one for a new getdirentries(2). > > > - the old/current getdirentries(2) uses the old > > > VOP_READDIR32() by default. > > > > > > For the case of a file system that supports both > > > the new and old VOP_READDIR(), they are used by > > > the corresponding new and old getdirentries(2) > > > syscalls. > > > > > > For a file system that only supports one of > > > the VOP_READDIR()s, the "struct dirent32" > > > is copied to "struct dirent" (or vice versa). > > > > > > At this point, all file systems would support > > > the old VOP_READDIR() and I think the new > > > VOP_READDIR() can easily be added for NFS, > > > ZFS. (OpenBSD already has UFS code for > > > essentially a new struct dirent and hopefully > > > that code could be ported easily, too.) > > > > > > Anyhow, any comments on this approach? rick > > > > I think this is already done (along with several other changes) > > more fully in > > the projects/ino64 branch in svn? > > projects/ino64 was created by mdf for merging GSoC commits, and it > didn't even get half way through. > > I'm currently working on merging the code to CURRENT. It's been more > than 2 years, so there is quite some work in there. I intend to > update > the branch as soon as code is ready for review. > > Besides branch also changes dev_t to 64-bit, bumps MNAMELEN to 1024 > and > has complete ABI compatibility shims (probably except openaudit which > had > issues). > I was aware of Gleb's work and had pinged him to see if he could update his patch. (I'll admit I wasn't aware of projects/ino64 until this morning.) It was my understanding (which could be wrong) that the d_fileno field of "struct dirent" was a tricky bit that hadn't yet been solved (I could be wrong) and started there. I am certainly hoping that Gleb can find the time to update projects/ino64. (I will take a look at what is there now to see what was done w.r.t. d_fileno.) rick > > _______________________________________________ > freebsd-fs@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" >