From owner-dev-commits-src-all@freebsd.org Thu Feb 18 00:48:24 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AEB6C53F9F9; Thu, 18 Feb 2021 00:48:24 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dgx084b0zz4VrD; Thu, 18 Feb 2021 00:48:24 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (unknown [IPv6:2601:648:8681:1cb0:4492:1dca:b2dc:b55d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 35A24462; Thu, 18 Feb 2021 00:48:24 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: git: 24fd63e0970f - main - mips: Don't set __NO_TLS to disable some uses of TLS. From: John Baldwin To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202102180035.11I0ZnL3070354@gitrepo.freebsd.org> Message-ID: <9687575c-dd7c-1496-850b-2018f4bca3da@FreeBSD.org> Date: Wed, 17 Feb 2021 16:48:22 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <202102180035.11I0ZnL3070354@gitrepo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2021 00:48:24 -0000 On 2/17/21 4:35 PM, John Baldwin wrote: > The branch main has been updated by jhb: > > URL: https://cgit.FreeBSD.org/src/commit/?id=24fd63e0970f91189dd2acde987bd2e4c8c04a50 > > commit 24fd63e0970f91189dd2acde987bd2e4c8c04a50 > Author: John Baldwin > AuthorDate: 2021-02-18 00:34:23 +0000 > Commit: John Baldwin > CommitDate: 2021-02-18 00:34:23 +0000 > > mips: Don't set __NO_TLS to disable some uses of TLS. > > __NO_TLS was originally added to disable use of _Thread in the locale > code in libc in 82dd5016bd749d1d9e1531bd1703aebeecceab34. At the time > libc did not support TLS on MIPS (I believe), but TLS support was > added to libc (at least _set_tp.c) for MIPS about a month after > __NO_TLS was added, but __NO_TLS was still left around. > > Reviewed by: imp > Sponsored by: DARPA > Differential Revision: https://reviews.freebsd.org/D28713 > --- > sys/sys/cdefs.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/sys/sys/cdefs.h b/sys/sys/cdefs.h > index 64f26480a2f5..ff18911f6acf 100644 > --- a/sys/sys/cdefs.h > +++ b/sys/sys/cdefs.h > @@ -768,8 +768,7 @@ > #endif > #endif /* __STDC_WANT_LIB_EXT1__ */ > > -#if defined(__mips) || \ > - (defined(__powerpc64__) && (!defined(_CALL_ELF) || _CALL_ELF == 1)) > +#if defined(__powerpc64__) && (!defined(_CALL_ELF) || _CALL_ELF == 1) > #define __NO_TLS 1 > #endif It would be really nice to kill __NO_TLS entirely. There is at least one unconditional use of _Thread_local (sorry, should have used that instead of _Thread above) in libc in stdlib/cxa_thread_atexit_impl.c, so it seems highly unlikely that TLS is actually broken on any of our platforms as the libc build would have been broken instead. -- John Baldwin