From owner-freebsd-arch@FreeBSD.ORG Thu Nov 13 09:38:58 2014 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 95EA1EFB; Thu, 13 Nov 2014 09:38:58 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0642BCA6; Thu, 13 Nov 2014 09:38:57 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id sAD9cquY099473 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 13 Nov 2014 11:38:52 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua sAD9cquY099473 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id sAD9cqM9099472; Thu, 13 Nov 2014 11:38:52 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 13 Nov 2014 11:38:52 +0200 From: Konstantin Belousov To: Jilles Tjoelker Subject: Re: Removal of kern_xxx() no-at variants. Message-ID: <20141113093852.GU17068@kib.kiev.ua> References: <20141112132451.GM17068@kib.kiev.ua> <201411121014.04482.jhb@freebsd.org> <5463C39C.2010204@FreeBSD.org> <20141112223144.GA90037@stack.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141112223144.GA90037@stack.nl> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: Benjamin Kaduk , freebsd-arch@freebsd.org, fs@freebsd.org, Jonathan Anderson , arch@freebsd.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Nov 2014 09:38:58 -0000 On Wed, Nov 12, 2014 at 11:31:45PM +0100, Jilles Tjoelker wrote: > On Wed, Nov 12, 2014 at 05:01:24PM -0330, Jonathan Anderson wrote: > > A thought: > > > If we're only going to have one of {kern_open,kern_openat}, might it > > make sense to keep the shorter name rather than the longer one? > > kern_openat as a name seems meaningful to me only if we're trying to > > disambiguate it from an also-existent-but-different-meaning kern_open. > > The name kern_openat makes sense in that the functionality is like the > openat() system call. I like the proposal, but think that it is premature, unfortunately. Issue is the MFC to stable branches, which still have old functions used in code. I do not mean merge of this change to stable, but other merges which intersect with the at/no-at modifications. Having kern_open() as different functions in HEAD and stable is too confusing without real value IMO. Note that it is possible to partially MFC the commit into stable, leaving the removal of the no-at variants out of the patch.