From owner-freebsd-ports@FreeBSD.ORG Thu Nov 13 00:36:09 2014 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 18D4FB49 for ; Thu, 13 Nov 2014 00:36:09 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D766A13E for ; Thu, 13 Nov 2014 00:36:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id sAD0a8Vx087074 for ; Thu, 13 Nov 2014 00:36:08 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id sAD0a8nf087072 for ports@FreeBSD.org; Thu, 13 Nov 2014 00:36:08 GMT (envelope-from bdrewery) Received: (qmail 56880 invoked from network); 12 Nov 2014 18:36:06 -0600 Received: from unknown (HELO ?10.10.0.24?) (freebsd@shatow.net@10.10.0.24) by sweb.xzibition.com with ESMTPA; 12 Nov 2014 18:36:06 -0600 Message-ID: <5463FCF6.4040901@FreeBSD.org> Date: Wed, 12 Nov 2014 18:36:06 -0600 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: John-Mark Gurney , ports@FreeBSD.org Subject: Re: review of new tcpcrypt port... References: <20141108100709.GF24601@funkthat.com> <20141113001649.GB24601@funkthat.com> In-Reply-To: <20141113001649.GB24601@funkthat.com> OpenPGP: id=6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="JefkX3LpcR8LoLEIgltJCdq92K6wLRNd3" X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Nov 2014 00:36:09 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JefkX3LpcR8LoLEIgltJCdq92K6wLRNd3 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 11/12/2014 6:16 PM, John-Mark Gurney wrote: > John-Mark Gurney wrote this message on Sat, Nov 08, 2014 at 02:07 -0800= : >> I'd like someone to review the attached port for me to commit... It >> contains a daemon to run on divert sockets to implement the tcpcrypt >> protocol. I have tested this port w/ HEAD and it works fine w/ the >> attached patch... >> >> The included patch has been submitted upstream and committed, but a >> new release has not yet been released. >> >> portlint -A looks fine. >=20 > As I haven't received a review, in a couple more days, probably Friday,= > I'll commit the port... >=20 > Thanks. >=20 Can you include the security/Makefile bit in the patch too please? Have you ran it through poudriere? At the very least 'env DEVELOPER=3D1 make stage' and 'make check-plist' are required. Portlint is not sufficient, nor can it even be trusted in all cases. If you check those and get back to me I'll approve it. Usually you'd need a port commit bit to commit anything, or an approval (which is different than a review). I hate our process, but that's how it is. Poke people in #bsdports on EFNet, or me on IRC, for approvals/reviews in the future. --=20 Regards, Bryan Drewery --JefkX3LpcR8LoLEIgltJCdq92K6wLRNd3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJUY/z2AAoJEDXXcbtuRpfP8GMH/jstXWoO9F9jZPGMUt1zSS9m gqLfMbbBnEGImTFyYipLpup/GET7qm7AQzdvrwFFcUZ6h7RXn4Ih6J+B3HaRA61w wKtuOQOGuaBirUDSOSZ7YXA5mUyCV+1MVhzC/9iiHo/nKZB3VB7m8XlpUcrYwjrO 22aj76i9mgiwi+Z4LUqf07ScQHZELBb1cbqX4idU/+NyKqQbSS+TI54JeMa90aW4 dHV7mEPp8g3UyO9Bh3Rwd0LEjkbBw8CsVt5Y2Y/bOgh76nZjb0QFzSVWebH7utS4 rTSx+AVoxe508FJnAruJmhcLYQFlBSWe/d9ZlYXCZXYBN6x9uvmymqFEJBufMdY= =yGvT -----END PGP SIGNATURE----- --JefkX3LpcR8LoLEIgltJCdq92K6wLRNd3--