From owner-svn-src-head@freebsd.org Sat Nov 4 16:46:38 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 81D7DE4FC64 for ; Sat, 4 Nov 2017 16:46:38 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: from asp.reflexion.net (outbound-mail-210-164.reflexion.net [208.70.210.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 455F175353 for ; Sat, 4 Nov 2017 16:46:37 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: (qmail 14033 invoked from network); 4 Nov 2017 16:46:31 -0000 Received: from unknown (HELO rtc-sm-01.app.dca.reflexion.local) (10.81.150.1) by 0 (rfx-qmail) with SMTP; 4 Nov 2017 16:46:31 -0000 Received: by rtc-sm-01.app.dca.reflexion.local (Reflexion email security v8.40.3) with SMTP; Sat, 04 Nov 2017 12:46:31 -0400 (EDT) Received: (qmail 9619 invoked from network); 4 Nov 2017 16:46:30 -0000 Received: from unknown (HELO iron2.pdx.net) (69.64.224.71) by 0 (rfx-qmail) with (AES256-SHA encrypted) SMTP; 4 Nov 2017 16:46:30 -0000 Received: from [192.168.1.25] (c-76-115-7-162.hsd1.or.comcast.net [76.115.7.162]) by iron2.pdx.net (Postfix) with ESMTPSA id 410EDEC8074; Sat, 4 Nov 2017 09:46:30 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate] From: Mark Millard In-Reply-To: Date: Sat, 4 Nov 2017 09:46:29 -0700 Cc: FreeBSD Toolchain , svn-src-head@freebsd.org, FreeBSD Current Content-Transfer-Encoding: quoted-printable Message-Id: References: <6140C4E2-168F-4E5D-B3C2-717ECB67C980@dsl-only.net> <134eea8e-1a2e-d77c-f7fa-01e14db7f47b@FreeBSD.org> To: Andriy Gapon X-Mailer: Apple Mail (2.3273) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Nov 2017 16:46:38 -0000 On 2017-Nov-4, at 5:04 AM, Andriy Gapon wrote: > On 04/11/2017 13:41, Andriy Gapon wrote: >> On 04/11/2017 12:32, Mark Millard wrote: >>> if (int Err =3D ::posix_fallocate(FD, 0, Size)) { >>> if (Err !=3D EOPNOTSUPP) >>> return std::error_code(Err, std::generic_category()); >>> } >>=20 >> The commit message that you didn't include into your reply contains = some useful >> information that authors / maintainers of this code should probably = take into >> account: >>=20 >>> Please note that EINVAL is used to report that the underlying file = system >>> does not support the operation (POSIX.1-2008). >>=20 >> Here is a link for that: >> = http://pubs.opengroup.org/onlinepubs/9699919799/functions/posix_fallocate.= html I had no doubt about the change being required or per-specification and did not think to list the reference. It was more that world's use of fallocate was not reviewed and possibly adjusted first that caused problems. FYI: It appears that sqlite3 might use fallocate. And heimdal (via its sqlite3.c). I've not reviewed the details for any of the below that do not trace to the lld issue: # grep -rl "fallocate" /usr/src/* | more /usr/src/contrib/sqlite3/configure.ac /usr/src/contrib/sqlite3/configure /usr/src/contrib/sqlite3/sqlite3.c /usr/src/contrib/netbsd-tests/lib/libc/sys/t_posix_fallocate.c /usr/src/contrib/compiler-rt/lib/dfsan/libc_ubuntu1404_abilist.txt /usr/src/contrib/compiler-rt/include/sanitizer/linux_syscall_hooks.h /usr/src/contrib/llvm/lib/Support/Unix/Path.inc /usr/src/contrib/pjdfstest/configure.ac /usr/src/contrib/pjdfstest/tests/misc.sh /usr/src/contrib/pjdfstest/pjdfstest.c /usr/src/contrib/openbsm/NEWS /usr/src/contrib/openbsm/etc/audit_event /usr/src/crypto/heimdal/lib/sqlite/sqlite3.c /usr/src/lib/libc/sys/posix_fallocate.2 /usr/src/lib/libc/sys/Symbol.map /usr/src/lib/libc/sys/Makefile.inc /usr/src/lib/libc/tests/sys/Makefile /usr/src/lib/clang/include/llvm/Config/config.h /usr/src/share/man/man9/VOP_ALLOCATE.9 /usr/src/sys/compat/freebsd32/syscalls.master /usr/src/sys/compat/freebsd32/freebsd32_syscalls.c /usr/src/sys/compat/freebsd32/freebsd32_sysent.c /usr/src/sys/compat/freebsd32/capabilities.conf /usr/src/sys/compat/freebsd32/freebsd32_misc.c /usr/src/sys/compat/freebsd32/freebsd32_proto.h /usr/src/sys/compat/freebsd32/freebsd32_syscall.h /usr/src/sys/compat/freebsd32/freebsd32_systrace_args.c /usr/src/sys/compat/cloudabi/cloudabi_file.c /usr/src/sys/compat/linux/linux_file.c /usr/src/sys/i386/linux/linux_sysent.c /usr/src/sys/i386/linux/linux_proto.h /usr/src/sys/i386/linux/linux_syscalls.c /usr/src/sys/i386/linux/linux_systrace_args.c /usr/src/sys/i386/linux/linux_syscall.h /usr/src/sys/i386/linux/syscalls.master /usr/src/sys/sys/fcntl.h /usr/src/sys/sys/syscall.h /usr/src/sys/sys/syscall.mk /usr/src/sys/sys/syscallsubr.h /usr/src/sys/sys/sysproto.h /usr/src/sys/kern/init_sysent.c /usr/src/sys/kern/syscalls.master /usr/src/sys/kern/systrace_args.c /usr/src/sys/kern/capabilities.conf /usr/src/sys/kern/vfs_syscalls.c /usr/src/sys/kern/syscalls.c /usr/src/sys/amd64/linux32/linux32_syscall.h /usr/src/sys/amd64/linux32/linux32_systrace_args.c /usr/src/sys/amd64/linux32/syscalls.master /usr/src/sys/amd64/linux32/linux32_syscalls.c /usr/src/sys/amd64/linux32/linux32_sysent.c /usr/src/sys/amd64/linux32/linux32_proto.h /usr/src/sys/amd64/linux/linux_proto.h /usr/src/sys/amd64/linux/syscalls.master /usr/src/sys/amd64/linux/linux_syscalls.c /usr/src/sys/amd64/linux/linux_systrace_args.c /usr/src/sys/amd64/linux/linux_syscall.h /usr/src/sys/amd64/linux/linux_sysent.c /usr/src/tests/sys/pjdfstest/config.h > My response above is quite dry, so I want to add this. > Thank you very much for the deep analysis. > I am sorry for the trouble that my change caused, but I think that its = root > cause lies elsewhere (lld, posix). You are welcome. --=20 Andriy Gapon