From owner-freebsd-hackers@FreeBSD.ORG  Fri Feb  4 10:27:48 2011
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DFFB8106564A;
	Fri,  4 Feb 2011 10:27:48 +0000 (UTC) (envelope-from rea@codelabs.ru)
Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.177.45])
	by mx1.freebsd.org (Postfix) with ESMTP id 017318FC1D;
	Fri,  4 Feb 2011 10:27:47 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codelabs.ru;
	s=two; 
	h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date;
	bh=O3zByGMcubrcRQfKAvkbExnA5TZ+F+8t2acnpT0H/jU=; 
	b=kgKBgxgsDurflpBbT8nMzWRHKioMraQ4mfz6g2WJ3wzyu7vYxSyaDSxHrrFueOquXVs4FarjHXt6tK8oebamUJrHC8jno3w39tmO3fGud4u9U854WP1OUYEqs3fv9BXlpx+MYxq6HoGF+lw2AR9Z+4yFjxTLuUNDzP665PmmSdN354ugZzd22ur0ilD2bqGzzEsa9i/d6AgkMw4fPge3EqpRJcUycy3uiIZKJuRgzVmEwxLftPCyOmGxTxEORGf0DgSjLfeVUs4sYTJZGIC+isEAsQgkZad69A9FwgHGNAnV0JcTzRs9f3KRtFs8qw+LCY1AZDqTBvb3TsOB61DFAg==;
Received: from void.codelabs.ru (void.codelabs.ru [144.206.177.25])
	by 0.mx.codelabs.ru with esmtpsa (TLSv1:AES256-SHA:256)
	id 1PlItH-000Ibv-0b; Fri, 04 Feb 2011 13:27:47 +0300
Date: Fri, 4 Feb 2011 13:27:44 +0300
From: Eygene Ryabinkin <rea@freebsd.org>
To: Alexander Best <arundel@freebsd.org>
Message-ID: <WCdx7jY8CkUDEYZsZo35TNdHcug@QsmfhJNucgI88DfvPJdT1/nyboE>
References: <20110203194306.GA55376@freebsd.org>
	<tO0VRfG8IHdubUqZgtUh/v4OTF0@QsmfhJNucgI88DfvPJdT1/nyboE>
	<20110204102221.GA41464@freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Q8BnQc91gJZX4vDc"
Content-Disposition: inline
In-Reply-To: <20110204102221.GA41464@freebsd.org>
Sender: rea@codelabs.ru
Cc: freebsd-hackers@freebsd.org
Subject: Re: insufficient flag handling in tools/install.sh
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Feb 2011 10:27:49 -0000


--Q8BnQc91gJZX4vDc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Alexander, good day.

Fri, Feb 04, 2011 at 10:22:21AM +0000, Alexander Best wrote:
> hi eygene. thanks a lot for your patch.

You're welcome ;))

> i made two changes:
>=20
> 1) also catch the -v option for install(1).

Yep.

> 2) install(1) accepts multiple directories as arguments, when he -d flag =
has
>    been specified. so i don't think it's necessary to iterate through all=
 the
>    directories passed to install.sh and invoke install(1) with only one
>    argument at a time.

I had overlooked that, thanks for spotting.

> could you take a look at the attached patch?

Looks fine and works for me, thanks!
--=20
Eygene Ryabinkin                                        ,,,^..^,,,
[ Life's unfair - but root password helps!           | codelabs.ru ]
[ 82FE 06BC D497 C0DE 49EC  4FF0 16AF 9EAE 8152 ECFB | freebsd.org ]

--Q8BnQc91gJZX4vDc
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (FreeBSD)

iF4EAREIAAYFAk1L1KAACgkQFq+eroFS7PuCRAD8DzZ4ABG+tENiUlcsUHAlZXxc
hYGmr2H2dYePvPFZfXEA/1aAF7azCnbRYisBd7dvIplwQ4hLjmPrl6NK9KQUTRwq
=52Cf
-----END PGP SIGNATURE-----

--Q8BnQc91gJZX4vDc--