From nobody Wed May 27 21:46:37 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gQjr26C4wz6fknS for ; Wed, 27 May 2026 21:46:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gQjr25Ns9z3YDj for ; Wed, 27 May 2026 21:46:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779918402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WVX26dXCXCw76SIapqWnxWdvEgdy7SsyIvV9rNFn+UE=; b=hu4B+dfr5vNH8iJVyO2mEkskYSp1X+hjhnH7sLQoqy+/pc4QqLipqltFgMiozWUGdLFHEh WvOFHNWSGfgVN3w2+MOcJEUM/+wXOEYbAwwc4+9+NuAsMwZvbmXsVHik3qVcyZETW3QIm6 5XB5VUUVyWd5IEvLsRcg1ks7u3Zn+ALmd5sFLimP/cDxCFInOgS7JXQXyNA6QpdTd0kUwt 9MJ0xOOuJWi4UVuwtNfRENGQfkxeqau7nE/qgPXxatJKyPjxnZRahAFT1miRNv5q666HON AvcsmyqGZbMaq6cPDwAH7gAvsVKi5hVl5tAaVAwwjVBBGGDL8Lxfjg7FE1Mlng== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779918402; a=rsa-sha256; cv=none; b=M0HIwKOmaT63H+3isDuQH20eCOxV0XrOmZmEffImWpo5oOz02uQb0YsbK4iQOG4UYT/rKz CRZxP1uY/gJ+NI+7EEf1sqJ8G6sDfcJ44uaeaULs7M0iDminH1nzhvaJFUNsV1BhevQNro 90AETHR+2IQMRiQvFjyyBu5XJnvO2Bx8bRa6lCiVr80Tf9ZOKd3CaMr5wx7qHKLgQbzSJ3 pX7bz9VUKttFbVmSPwF2ci4NhqwyUt7ROhIqvKTAPKB0AXG3/+NjvPPjt6NOARAycfhw+u c/Pm+BgP9LXyrFGhP4DGB3pAxo2Mf7J9+VhmWqYi8lkeKZs/gn59uSCzO5furw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779918402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WVX26dXCXCw76SIapqWnxWdvEgdy7SsyIvV9rNFn+UE=; b=kT3cPy98BVx71SozTA7doUcl7uPMgk35iF4uKAX2xSi98EZRG+U7MB81w4Dc0NwdVOLSlm 45KweKTJv6DNxt2Nfwh8brSgc1Z9J9dr6SEtIMJwdAcpcXuO5l7WckVnx1dHZ2COS8Ooe/ yr3xstAzgskBBn7rVnv1WCSqT4pIYe7ss3lqLcXjgO1TDGhbeUhDvIxXERiYb0CL7uTdnB OTC7fBuhz+2qOftCSZBvb/BebC8n91e16V11TuSPc8t1JYJkIHQ3snHdfy/xE+SskXU0K4 0RTRLKdculB0xc6uzznY3wWucghrPm1X8Kq3bUoz0wqHXPkEeC0zTg7dwRxX0A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gQjr24nQKz2r5 for ; Wed, 27 May 2026 21:46:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 252f7 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 27 May 2026 21:46:37 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Alex Richardson From: Dimitry Andric Subject: git: 1ebf5f54ada8 - stable/14 - if_ovpn.c: fix use of uninitialized variable List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 1ebf5f54ada8a35c736a16ea07fb2057021c0e65 Auto-Submitted: auto-generated Date: Wed, 27 May 2026 21:46:37 +0000 Message-Id: <6a17663d.252f7.4783dada@gitrepo.freebsd.org> The branch stable/14 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=1ebf5f54ada8a35c736a16ea07fb2057021c0e65 commit 1ebf5f54ada8a35c736a16ea07fb2057021c0e65 Author: Alex Richardson AuthorDate: 2025-09-15 22:08:43 +0000 Commit: Dimitry Andric CommitDate: 2026-05-27 21:41:13 +0000 if_ovpn.c: fix use of uninitialized variable In case we use OVPN_CIPHER_ALG_NONE, the memcpy will attempt to copy 0 bytes from an uninitialized pointer. While the memcpy() implementation will treat this as a no-op and not actually dereferece the undefined variable it is still undefined behaviour to the compiler and should be fixed. Found by building with clang HEAD Reviewed by: kp MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D52543 (cherry picked from commit 969be39fb3caf4272f128dbf3267ceba5966a6ce) --- sys/net/if_ovpn.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/net/if_ovpn.c b/sys/net/if_ovpn.c index 1037154f26b5..3a04249ec554 100644 --- a/sys/net/if_ovpn.c +++ b/sys/net/if_ovpn.c @@ -951,9 +951,11 @@ ovpn_create_kkey_dir(struct ovpn_kkey_dir **kdirp, kdir->cipher = cipher; kdir->keylen = keylen; kdir->tx_seq = 1; - memcpy(kdir->key, key, keylen); + if (keylen != 0) + memcpy(kdir->key, key, keylen); kdir->noncelen = ivlen; - memcpy(kdir->nonce, iv, ivlen); + if (ivlen != 0) + memcpy(kdir->nonce, iv, ivlen); if (kdir->cipher != OVPN_CIPHER_ALG_NONE) { /* Crypto init */