From owner-freebsd-questions@FreeBSD.ORG Sat Dec 2 23:14:59 2006 Return-Path: X-Original-To: freebsd-questions@freebsd.org Delivered-To: freebsd-questions@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3DE9916A407 for ; Sat, 2 Dec 2006 23:14:59 +0000 (UTC) (envelope-from youshi10@u.washington.edu) Received: from mxout4.cac.washington.edu (mxout4.cac.washington.edu [140.142.33.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 18AEC43CAC for ; Sat, 2 Dec 2006 23:14:08 +0000 (GMT) (envelope-from youshi10@u.washington.edu) Received: from smtp.washington.edu (smtp.washington.edu [140.142.33.9]) by mxout4.cac.washington.edu (8.13.7+UW06.06/8.13.7+UW06.09) with ESMTP id kB2NERhb028347 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 2 Dec 2006 15:14:28 -0800 X-Auth-Received: from [192.168.0.101] (dsl254-013-145.sea1.dsl.speakeasy.net [216.254.13.145]) (authenticated authid=youshi10) by smtp.washington.edu (8.13.7+UW06.06/8.13.7+UW06.09) with ESMTP id kB2NERND024473 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sat, 2 Dec 2006 15:14:27 -0800 Message-ID: <457208D3.1010508@u.washington.edu> Date: Sat, 02 Dec 2006 15:14:27 -0800 From: Garrett Cooper User-Agent: Thunderbird 1.5.0.8 (X11/20061116) MIME-Version: 1.0 To: freebsd-questions@freebsd.org References: <20061202074631.S84600@scorpio.seibercom.net> <200612021748.18100.fbsd06@mlists.homeunix.com> <4571EF71.4000005@u.washington.edu> <200612022152.14049.fbsd06@mlists.homeunix.com> In-Reply-To: <200612022152.14049.fbsd06@mlists.homeunix.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-PMX-Version: 5.2.2.285561, Antispam-Engine: 2.5.0.283055, Antispam-Data: 2006.12.2.145933 X-Uwash-Spam: Gauge=IIIIIII, Probability=7%, Report='__CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_MSGID 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __SANE_MSGID 0, __USER_AGENT 0' Subject: Re: pkgtools.conf error with portmanager X-BeenThere: freebsd-questions@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: User questions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Dec 2006 23:14:59 -0000 RW wrote: > On Saturday 02 December 2006 21:26, Garrett Cooper wrote: >> RW wrote: > >>> My patch file is below. >>> >>> $ cd /usr/ports/sysutils/portmanager/ && cat files/patch-no-ruby-support >>> --- libMGPM/src/MGPMrReadConfigure.c.orig Sat Dec 2 17:10:45 2006 >>> +++ libMGPM/src/MGPMrReadConfigure.c Sat Dec 2 17:11:37 2006 >>> @@ -190,9 +190,7 @@ >>> MGmStrcpy( portupgradeFileName, PREFIXDIR ); >>> MGmStrcat( portupgradeFileName, "/sbin/portupgrade" ); >>> >>> - if( MGrIfFileExist( rubyFileName ) && >>> - MGrIfFileExist( pkgtoolsFileName ) && >>> - MGrIfFileExist( portupgradeFileName ) ) >>> + if( 0 ) >>> { >>> /* >>> * run ruby script >> I assume ruby follows the same conventions as many other procedural >> languages ( 0 is false, non-0 is true). >> > I've no idea about ruby, the patch is to MGPMrReadConfigure.c > >> If so, why are you preventing >> the lines below if( 0 ) from running in your patch given above? Might as >> well comment out or delete the following lines because they won't be >> evaluated and run.. > > True, but that would be more effort, so I might as well not; and keeping it > simple reduces the chance of a conflict with a future patch. And it's not as > if anyone is ever going to permanently integrate this patch into the source > files. You do realize portupgrade is ruby based though, do you not? [gcooper@hoover /usr/src/crypto/openssh]$ head -n 1 /usr/local/sbin/portupgrade #!/usr/local/bin/ruby18 -Garrett