Date: Thu, 9 Jun 2016 06:25:34 -0700 From: "Simon J. Gerraty" <sjg@juniper.net> To: Glen Barber <gjb@FreeBSD.org> Cc: <src-committers@FreeBSD.org>, <svn-src-all@FreeBSD.org>, <svn-src-head@FreeBSD.org>, <sjg@juniper.net>, <stevek@juniper.net> Subject: Re: svn commit: r301713 - head/sys/dev/random Message-ID: <90183.1465478734@kaos.jnpr.net> In-Reply-To: <20160609130108.GN2323@FreeBSD.org> References: <201606090150.u591ohZa019497@repo.freebsd.org> <20160609130108.GN2323@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Glen Barber <gjb@FreeBSD.org> wrote: > > = > > -void read_rate_increment(u_int); > > +void random_harvest_queue(const void *, u_int, u_int, > > + enum random_entropy_source); > > +void read_rate_increment(u_int); > > = > > #define RANDOM_HARVESTQ_BOOT_ENTROPY_FILE "/boot/entropy" > > = > = > This breaks sparc64. Looks like defined(DEV_RANDOM) is relevant. Wrapping the prototype in random_harvestq.h in #ifndef DEV_RANDOM would avoid this issue. But backing out until we check if that fixes the original issue steve hit is probably best? > = > cc1: warnings being treated as errors > In file included from /usr/src/sys/modules/random_other/../../dev/random= /other_algorithm.c:62: > /usr/src/sys/dev/random/random_harvestq.h:47: warning: redundant redecla= ration of 'random_harvest_queue' [-Wredundant-decls] > /usr/src/sys/sys/random.h:99: warning: previous declaration of 'random_h= arvest_queue' was here > = > Glen > =
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?90183.1465478734>