From owner-svn-src-all@freebsd.org Sat Aug 31 23:28:52 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CB368E24D0; Sat, 31 Aug 2019 23:28:52 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46LXbm51nnz4PFs; Sat, 31 Aug 2019 23:28:52 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f47.google.com with SMTP id d25so19418314iob.6; Sat, 31 Aug 2019 16:28:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=EEcKzJO7KoEbW0gO6ktFs132/4F638h7Tq9/24XE8bM=; b=UGaJ6GUmfKOaK0WXSdVZPzpFLvlITFyq+1ByA0nssxHfLBWMzz0eZq6PDq9500Wl4F k4VrwvCeiJCiAa6LSXkXlLW3KhtWRUH46kqB2gkOeTG+W4rR+p2U+jZFEXgRARF/bN02 VfYd3UBTDPuhoVfaIg8HCSUfhYUwoB+SpTykZTZjXkSLZwEQCz4VapCmB137+DdDlvuD cWyMZhKS3B+G3ZCAYygTtmJIVGzXoPN9cGUQwKMSQMG04dexdj3IHo04iJYtyJQKPZB5 7zC48NJV6Va0AIuI2Kj6hPW9cT5oU0TnX0IAsYgszg6UFw79TqzposBhcTUhsfYknYpG jfdw== X-Gm-Message-State: APjAAAXJANjeY5IPj69uh1fvqOLPnDEH7r72YNJOLtSyFjxGkS2O/2Jk ioUBb3yulWuXfx0GzL1RpmIEWBvC X-Google-Smtp-Source: APXvYqypZ438RghmTOyLRSqwqyLPcg8961/CqNzhmm74nBKZLVlYnWtoSD0YCFGFNxVVzQBhtR1ERQ== X-Received: by 2002:a6b:f717:: with SMTP id k23mr13188198iog.210.1567294131400; Sat, 31 Aug 2019 16:28:51 -0700 (PDT) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com. [209.85.166.42]) by smtp.gmail.com with ESMTPSA id r2sm7337963ioh.61.2019.08.31.16.28.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Aug 2019 16:28:50 -0700 (PDT) Received: by mail-io1-f42.google.com with SMTP id f12so4430518iog.12; Sat, 31 Aug 2019 16:28:50 -0700 (PDT) X-Received: by 2002:a5e:a80f:: with SMTP id c15mr8992974ioa.270.1567294130667; Sat, 31 Aug 2019 16:28:50 -0700 (PDT) MIME-Version: 1.0 References: <201908311441.x7VEfwZ3045957@repo.freebsd.org> In-Reply-To: <201908311441.x7VEfwZ3045957@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sat, 31 Aug 2019 16:28:39 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r351643 - in head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common: dtraceUtil speculation To: Li-Wen Hsu Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46LXbm51nnz4PFs X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.977,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Aug 2019 23:28:52 -0000 Thanks Li-Wen! Might it be less fragile to have the test fixture create a file, if the test(s) will expect one to be present to read? On Sat, Aug 31, 2019 at 7:42 AM Li-Wen Hsu wrote: > > Author: lwhsu > Date: Sat Aug 31 14:41:58 2019 > New Revision: 351643 > URL: https://svnweb.freebsd.org/changeset/base/351643 > > Log: > Fix tests use /etc/motd after r350184 by using an always existing file > > Sponsored by: The FreeBSD Foundation > > Modified: > head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.DestructWithFunction.d.ksh > head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.ZeroFunctionProbes.d.ksh > head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/speculation/tst.NoSpecBuffer.exe > > Modified: head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.DestructWithFunction.d.ksh > ============================================================================== > --- head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.DestructWithFunction.d.ksh Sat Aug 31 13:24:22 2019 (r351642) > +++ head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.DestructWithFunction.d.ksh Sat Aug 31 14:41:58 2019 (r351643) > @@ -43,7 +43,7 @@ reader() > while true > do > sleep 0.1 > - cat /etc/motd > /dev/null > + cat /COPYRIGHT > /dev/null > done > } > > > Modified: head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.ZeroFunctionProbes.d.ksh > ============================================================================== > --- head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.ZeroFunctionProbes.d.ksh Sat Aug 31 13:24:22 2019 (r351642) > +++ head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.ZeroFunctionProbes.d.ksh Sat Aug 31 14:41:58 2019 (r351643) > @@ -44,7 +44,7 @@ reader() > while true > do > sleep 0.1 > - cat /etc/motd > /dev/null > + cat /COPYRIGHT > /dev/null > done > } > > > Modified: head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/speculation/tst.NoSpecBuffer.exe > ============================================================================== > --- head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/speculation/tst.NoSpecBuffer.exe Sat Aug 31 13:24:22 2019 (r351642) > +++ head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/speculation/tst.NoSpecBuffer.exe Sat Aug 31 14:41:58 2019 (r351643) > @@ -26,5 +26,5 @@ > while true > do > sleep 0.1 > - cat /etc/motd > /dev/null > + cat /COPYRIGHT > /dev/null > done >