Date: Sun, 15 Jan 2012 12:35:04 +0600 From: Yar <yarodin@gmail.com> To: poyopoyo@puripuri.plala.or.jp Cc: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/archivers/unrar Makefile Message-ID: <147869552.20120115123504@gmail.com> In-Reply-To: <8662gfjd02.wl%poyopoyo@puripuri.plala.or.jp> References: <201201080930.q089UX6D091198@repoman.freebsd.org> <8662gfjd02.wl%poyopoyo@puripuri.plala.or.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
------------11D1B60F1078BA4C3
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Hello Poyopoyo,
Saturday, January 14, 2012, 7:20:45, you wrote:
> At Sun, 8 Jan 2012 09:30:33 +0000 (UTC),
> Sunpoet Po-Chuan Hsieh wrote:
>> @@ -24,6 +24,9 @@ MAKEFILE= makefile.unix
>> PLIST_FILES= bin/unrar
>> PORTDOCS= license.txt readme.txt
>>
>> +post-patch:
>> + @${REINPLACE_CMD} -e '/^CXX/ s|^|#|' ${WRKSRC}/${MAKEFILE}
>> +
>> do-install:
>> ${INSTALL_PROGRAM} ${WRKSRC}/unrar ${PREFIX}/bin
>> .if !defined(NOPORTDOCS)
> Hi,
> Commenting CXX* out after patch phase breaks unrar-iconv since it
> requires CXXFLAGS to be set in makefile.unix.
===>> Building for unrar-iconv-4.10,5
> c++ -O2 -pipe -march=native -fno-strict-aliasing
> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DWITH_ICONV -DUNRAR -c rar.cpp
> In file included from rar.hpp:5,
> from rar.cpp:1:
> os.hpp:197:19: error: iconv.h: No such file or directory
> In file included from rar.hpp:76,
> from rar.cpp:1:
> global.hpp:19: error: 'iconv_t' does not name a type
> global.hpp:20: error: 'iconv_t' does not name a type
> gmake: *** [rar.o] Error 1
> *** Error code 1
> Here's a candidate:
> - Comment CXX* out for only unrar not for unrar-iconv.
I vote for it! \if !defined(USE_ICONV) at unrar Makefile\.
It's more accuracy at my point of view.
> - in unrar-iconv do the same thing with files/patch-iconv.
BUT :) I attached tiny patch for unrar-iconv/Makefile
with dirty workaround.
--
Best regards,
Yar mailto:yarodin@gmail.com
------------11D1B60F1078BA4C3
Content-Type: application/octet-stream;
name="unrar-iconv_Makefile.patch"
Content-transfer-encoding: base64
Content-Disposition: attachment;
filename="unrar-iconv_Makefile.patch"
LS0tIE1ha2VmaWxlLm9yaWcJMjAxMi0wMS0xNSAxMjoyMDoxNy4wMDAwMDAwMDAgKzA3MDAK
KysrIE1ha2VmaWxlCTIwMTItMDEtMTUgMTI6MTk6NDQuMDAwMDAwMDAwICswNzAwCkBAIC0x
Nyw2ICsxNyw5IEBACiAKIENPTkZMSUNUUz0JdW5yYXItWzAtOV0qIHpoLXVucmFyLVswLTld
KgogCitwcmUtYnVpbGQ6CisJQCR7UkVJTlBMQUNFX0NNRH0gLWUgJy9eI0NYWEZMQUdTKz0v
IHN8XiN8fCcgJHtXUktTUkN9LyR7TUFLRUZJTEV9CisKIHBvc3QtaW5zdGFsbDoKIAlAJHtF
Q0hPX01TR30gIj09PT4gQWRkZWQgaWNvbnYgc3VwcG9ydCwgc2VlIG5ldyBzd2l0Y2hlczoi
CiAJQCR7RUNIT19NU0d9ICIgICAgIGxhLCBsbCBhbmQgbG8gYXQgXCJ1bnJhciAtP1wiIgo=
------------11D1B60F1078BA4C3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?147869552.20120115123504>