From owner-freebsd-current Tue Jun 15 2:48:42 1999 Delivered-To: freebsd-current@freebsd.org Received: from apollo.backplane.com (apollo.backplane.com [209.157.86.2]) by hub.freebsd.org (Postfix) with ESMTP id 2F16714D14 for ; Tue, 15 Jun 1999 02:48:39 -0700 (PDT) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.9.3/8.9.1) id CAA15805; Tue, 15 Jun 1999 02:48:39 -0700 (PDT) (envelope-from dillon) Date: Tue, 15 Jun 1999 02:48:39 -0700 (PDT) From: Matthew Dillon Message-Id: <199906150948.CAA15805@apollo.backplane.com> To: Ville-Pertti Keinonen , current@FreeBSD.ORG Subject: Re: NFS vnode reference issues on server References: <199906150421.VAA14439@apollo.backplane.com.newsgate.clinet.fi> <86d7yxoqj6.fsf@not.demophon.com> <199906150839.BAA15539@apollo.backplane.com> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Here's another dandy: in nfsm_subs.h, the nfsm_reply() macro will happily return(). It really needs to 'goto nfsmout;' instead, or it bypasses all the procedural cleanup. Doh! Talk about leaving things hanging! nfs_serv.c isn't as bad as I thought... there are only a handful of routines which are badly broken, nfsrv_create() being one of them. I'll continue tomorrow. Er, later today. And I'll do some life testing on my test boxes before I post the patches. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message