Date: Fri, 28 Jul 2017 21:47:10 +0000 (UTC) From: Ryan Libby <rlibby@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r321669 - head/usr.sbin/bhyve Message-ID: <201707282147.v6SLlAub089265@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: rlibby Date: Fri Jul 28 21:47:10 2017 New Revision: 321669 URL: https://svnweb.freebsd.org/changeset/base/321669 Log: bhyve/vga.c: fix atc_color_select_67 bit shift Gcc noticed that the result of the bit shift is always zero. Shift so that the ATC_CS_C67 bits end up in bits 6 & 7. Reviewed by: grehan, tychon Approved by: markj (mentor) Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D11775 Modified: head/usr.sbin/bhyve/vga.c Modified: head/usr.sbin/bhyve/vga.c ============================================================================== --- head/usr.sbin/bhyve/vga.c Fri Jul 28 21:42:59 2017 (r321668) +++ head/usr.sbin/bhyve/vga.c Fri Jul 28 21:47:10 2017 (r321669) @@ -1069,7 +1069,7 @@ vga_port_out_handler(struct vmctx *ctx, int in, int po sc->vga_atc.atc_color_select_45 = (val & ATC_CS_C45) << 4; sc->vga_atc.atc_color_select_67 = - (val & ATC_CS_C67) << 6; + ((val & ATC_CS_C67) >> 2) << 6; break; default: //printf("XXX VGA ATC: outb 0x%04x, 0x%02x at index %d\n", port, val, sc->vga_atc.atc_index);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201707282147.v6SLlAub089265>