From owner-freebsd-arm@freebsd.org Sun Nov 17 14:29:36 2019 Return-Path: Delivered-To: freebsd-arm@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 397BB1C1B08 for ; Sun, 17 Nov 2019 14:29:36 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47GDxX0JKDz4MH4; Sun, 17 Nov 2019 14:29:36 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id D444F1DFC9; Sun, 17 Nov 2019 14:29:35 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qv1-f53.google.com with SMTP id x14so5517363qvu.0; Sun, 17 Nov 2019 06:29:35 -0800 (PST) X-Gm-Message-State: APjAAAWEdcr59JoFMPrnYqus6VMWDZh3H/ltmhaHoRLtp3CJm7FZGu/R GvIalEhWKamfEDh9jwtGz+OtUPNBFFZZguTNSu8= X-Google-Smtp-Source: APXvYqzcwJ3kVFnn6yAWyhj3ofbr5IEACbxkBtR9o5DR6JKWpnClZJYpnzTs5Td55jHj/0bVu+lJql9URcogCuTCJB4= X-Received: by 2002:a0c:d2b3:: with SMTP id q48mr16035535qvh.5.1574000975300; Sun, 17 Nov 2019 06:29:35 -0800 (PST) MIME-Version: 1.0 References: <2F178D6A-300B-4683-84D6-CDB6924877E5@FreeBSD.org> In-Reply-To: <2F178D6A-300B-4683-84D6-CDB6924877E5@FreeBSD.org> From: Kyle Evans Date: Sun, 17 Nov 2019 08:29:24 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Initial support for bcm2838 RNG To: Mark Murray Cc: Robert Crowston , "freebsd-arm@freebsd.org" , Conrad Meyer Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Nov 2019 14:29:36 -0000 On Sun, Nov 17, 2019 at 4:03 AM Mark Murray wrote: > > Hi, > > > On 16 Nov 2019, at 18:59, Kyle Evans wrote: > > > > On Sat, Nov 16, 2019 at 12:48 PM Robert Crowston via freebsd-arm > > wrote: > >> > >> I have made a first cut at supporting the Broadcom 2838 hardware random number generator, as found on the Raspberry Pi 4. > >> > >> Diff: https://github.com/freebsd/freebsd/compare/master...RobCrowston:pi4-hwrng > >> > >> This extends the existing bcm2835_rng.c driver to function on the Pi4. Unfortunately I do not have a Raspberry Pi 3 board to confirm it still works there, but on my Pi4, it generates (apparently) random numbers. > >> > > > > Hi, > > > > No worries- I've got access to a Pi 3 for regression testing. Can you > > throw what you've got into Phabricator [0] and add me as a reviewer? > > We can iterate/review from there. > > Please also add markm@ and cem@ (or csprng@). You'll need one of us to OK the commit. > Hi, (adding cem@ to CC list) Is there a document or something outlining what csprng@ wants to accomplish? I definitely don't object to adding you guys on this one (both because of the csprng@ origin story and this touches just enough actual RNG code path to warrant it, at a glance), but going forward- is csprng@ wanting to audit pre-existing stuff as it gets touched in any way (e.g. existing driver, just adding compatibility bits to make it probe/attach on new board), or just any new code actually affecting RNG? Thanks, Kyle Evans