From owner-svn-ports-all@FreeBSD.ORG Thu Apr 9 01:23:25 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A3247FD3 for ; Thu, 9 Apr 2015 01:23:25 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 80F71857 for ; Thu, 9 Apr 2015 01:23:25 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t391NOj7007458 for ; Thu, 9 Apr 2015 01:23:24 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t391NOPe007456 for svn-ports-all@freebsd.org; Thu, 9 Apr 2015 01:23:24 GMT (envelope-from bdrewery) Received: (qmail 62477 invoked from network); 8 Apr 2015 20:23:22 -0500 Received: from unknown (HELO ?10.10.1.139?) (freebsd@shatow.net@10.10.1.139) by sweb.xzibition.com with ESMTPA; 8 Apr 2015 20:23:22 -0500 Message-ID: <5525D48E.5090305@FreeBSD.org> Date: Wed, 08 Apr 2015 20:23:26 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Dmitry Marakasov Subject: Re: svn commit: r383191 - head/Mk References: <201504040535.t345ZJ9M028396@svn.freebsd.org> <20150408194202.GA45809@hades.panopticon> <5525A9C1.5010003@FreeBSD.org> <20150408232144.GX21982@hades.panopticon> In-Reply-To: <20150408232144.GX21982@hades.panopticon> OpenPGP: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Cgv6b6OHmFiKEvdRrUKFJFpIhGOg8tU24" Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Apr 2015 01:23:25 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Cgv6b6OHmFiKEvdRrUKFJFpIhGOg8tU24 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 4/8/2015 6:21 PM, Dmitry Marakasov wrote: > * Bryan Drewery (bdrewery@FreeBSD.org) wrote: >=20 >>>> Re-enable and rework check added in r370464 to validate the first = CATEGORY >>>> is set properly. The problem causing the revert in r370475 was fi= xed in >>>> r383190. >>>> =20 >>>> With hat: portmgr >>> >>> This breaks countless usecases when port is build which does not belo= ng >>> to the ports tree. >> >> Please name even 1 case. >=20 > I have a lot of WIP ports in flat directory. Tons of custom port > repositories on github with flat structure. Short of more details, that does not sound like a supported setup. I can't read your mind. Please give me a specific case or I can't help. >=20 >> Building a port with the wrong first CATEGORY results in a broken >> package as the origin is wrong. >=20 > I'm not talking about wrong categories, I'm talking about ports outside= > of the ports tree. These should build perfectly fine. >=20 >>> Afaik, we have that information in ports - based on >>> that PORTSDIR is chosen. The same mechanism should be used here to >>> conditionally enable the check. >> >> That made no sense. >=20 > Explain. >=20 I do not understand what you are trying to say. It makes no sense. --=20 Regards, Bryan Drewery --Cgv6b6OHmFiKEvdRrUKFJFpIhGOg8tU24 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVJdSOAAoJEDXXcbtuRpfPIPMIAIf1u3nzbstzk1ss2GYGRfOJ 8/sx0P17FX/Rx8eqlp6/KfTWQlkAAGlzh9i8aJMn/yFRJLmP0cTZ+Iaxk8tB9mpc 49aOtLJu80JdBmrhNfoS+2euo5JmjuCEndbdLGZFbfu2GJkBqRA1BGe++Ydf5b5y tZOpjcKk+UxU8A4ZUTVBB2dIieTARZkyFDF9aMP7QocytdBYt8mhrI+Bhb/zZn10 qhjztH2gB9aAhgnFVMBPa+gerWHLPfO3Q5siQSClXXeqMHb6fJEu2T50Pa0e/vSM mvmDIzzXS2KbRCIoXdAKsGwlrx0IXB03yp7JUhKhcAl0p5ItmK2kZqfHHrsMYdw= =16db -----END PGP SIGNATURE----- --Cgv6b6OHmFiKEvdRrUKFJFpIhGOg8tU24--