From owner-svn-src-head@FreeBSD.ORG Mon Jun 18 07:54:46 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D597F1065672; Mon, 18 Jun 2012 07:54:46 +0000 (UTC) (envelope-from phk@phk.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id 8FD428FC1F; Mon, 18 Jun 2012 07:54:46 +0000 (UTC) Received: from critter.freebsd.dk (critter.freebsd.dk [192.168.61.3]) by phk.freebsd.dk (Postfix) with ESMTP id 2F2DC13FB0; Mon, 18 Jun 2012 07:54:45 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.5/8.14.5) with ESMTP id q5I7shl3024167; Mon, 18 Jun 2012 07:54:44 GMT (envelope-from phk@phk.freebsd.dk) To: Taku YAMAMOTO From: "Poul-Henning Kamp" In-Reply-To: Your message of "Mon, 18 Jun 2012 06:29:12 +0900." <20120618062912.61088c11.taku@tackymt.homeip.net> Content-Type: text/plain; charset=ISO-8859-1 Date: Mon, 18 Jun 2012 07:54:43 +0000 Message-ID: <24166.1340006083@critter.freebsd.dk> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r237203 - head/sys/dev/fb X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2012 07:54:46 -0000 In message <20120618062912.61088c11.taku@tackymt.homeip.net>, Taku YAMAMOTO wri tes: >On Sun, 17 Jun 2012 21:02:48 +0000 (UTC) >Poul-Henning Kamp wrote: > >> Author: phk >> Date: Sun Jun 17 21:02:48 2012 >> New Revision: 237203 >> URL: http://svn.freebsd.org/changeset/base/237203 >> + >> +static __inline void >> +copyw(uint16_t *src, uint16_t *dst, size_t size) >> +{ >> + while (size--) >> + *dst++ = *src++; >> +} > >Does this end up with copying 2*size bytes instead of size bytes? Indeed it did. Thanks for spotting my mistake. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.