Date: Wed, 28 Jan 2015 17:28:59 +0000 (UTC) From: Josh Paetzel <jpaetzel@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r378074 - head/emulators/virtualbox-ose-kmod/files Message-ID: <201501281728.t0SHSx0E049097@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: jpaetzel Date: Wed Jan 28 17:28:58 2015 New Revision: 378074 URL: https://svnweb.freebsd.org/changeset/ports/378074 QAT: https://qat.redports.org/buildarchive/r378074/ Log: Fix circular dep issues so this script can DTRT at boot. This script needs to run after ldconfig, however it's deps cause: a) A circular dependancy in rcorder b) It starts before ldconfig This causes the VBoxManage command to bail out when it's run by this script because it can't find it's required libs. The consequence of this is host only networks aren't set up properly at boot. By removing the explicit dependancy on ldconfig we get rid of the circular dependancy issues. However since the VBoxManage command does actually need libraries in /usr/local/lib we set that explicitly with LD_LIBRARY_PATH. There's not really a good solution to this issue. The real "problem" is that /usr could be an NFS mount and you have to run ldconfig after /usr is mounted. While LD_LIBRARY_PATH is kind of ugly, and removing an explicit dependancy is ugly, the other alternatives are uglier. (Break NFS mounted /usr for example) I'd also argue that having this just not work (which is the state of it before this commit) is pretty ugly too. Also, I apologize in advance for not discussing this on emulation@ and just doing a drive by commit, however hopefully the fact that "This fixes obvious breakage" makes up for the fact that I skipped peer review, proper approval, and most importantly giving the community to bikeshed this ad naseum. Modified: head/emulators/virtualbox-ose-kmod/files/vboxnet.in Modified: head/emulators/virtualbox-ose-kmod/files/vboxnet.in ============================================================================== --- head/emulators/virtualbox-ose-kmod/files/vboxnet.in Wed Jan 28 17:21:58 2015 (r378073) +++ head/emulators/virtualbox-ose-kmod/files/vboxnet.in Wed Jan 28 17:28:58 2015 (r378074) @@ -5,7 +5,7 @@ # PROVIDE: vboxnet # BEFORE: NETWORKING -# REQUIRE: FILESYSTEMS ldconfig +# REQUIRE: FILESYSTEMS # KEYWORD: nojail # @@ -43,7 +43,7 @@ vboxnet_start() fi # initialize configured host-only interfaces - %%PREFIX%%/bin/VBoxManage list hostonlyifs >/dev/null + LD_LIBRARY_PATH=%%PREFIX%%/lib %%PREFIX%%/bin/VBoxManage list hostonlyifs >/dev/null } vboxnet_stop()
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201501281728.t0SHSx0E049097>