Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 Sep 2011 18:33:06 +0300
From:      Kostik Belousov <kostikbel@gmail.com>
To:        Hans Petter Selasky <hselasky@c2i.net>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>, "re@freebsd.org" <re@freebsd.org>, "svn-src-stable@freebsd.org" <svn-src-stable@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "Robert N. M. Watson" <rwatson@freebsd.org>, "svn-src-stable-8@freebsd.org" <svn-src-stable-8@freebsd.org>
Subject:   Re: Request for patch approval (Re: svn commit: r225458 - in stable/8/sys: dev/usb dev/usb/quirk dev/usb/storage sys)
Message-ID:  <20110910153306.GP17489@deviant.kiev.zoral.com.ua>
In-Reply-To: <201109101639.37581.hselasky@c2i.net>
References:  <201109101540.16656.hselasky@c2i.net> <20110910142812.GO17489@deviant.kiev.zoral.com.ua> <201109101639.37581.hselasky@c2i.net>

next in thread | previous in thread | raw e-mail | index | archive | help

--j4NZwBEUS1+1fgbv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Sep 10, 2011 at 04:39:37PM +0200, Hans Petter Selasky wrote:
> On Saturday 10 September 2011 16:28:12 Kostik Belousov wrote:
> > On Sat, Sep 10, 2011 at 03:40:16PM +0200, Hans Petter Selasky wrote:
> > > > Right -- exactly my point. If this change breaks third-party compil=
ed
> > > > USB device drivers, then our current approach to device driver KBIs
> > > > does not allow it to be MFC'd in this form. Are there ways you can
> > > > reformulate the change to avoid breaking those drivers? Sometimes t=
his
> > > > can be done by adding new symbols, rather than replacing currently
> > > > symbols, although mileage varies.
> > >=20
> > > Hi,
> > >=20
> > > Here is my proposal:
> > >=20
> > > Implement test for automatic quirks in function which has access to t=
he
> > > USB device structure. This decouples the structure change in "struct
> > > usbd_lookup_info".
> > >=20
> > > The only structure which needs change is "struct usb_device". In
> > > 9-current this structure will be kept as is. In 8-stable the new elem=
ent
> > > will be moved to the end of the structure like suggested, and then th=
ere
> > > shouldn't be any problems.
> > >=20
> > > Please find patches attached.
> > >=20
> > > --HPS
> > >=20
> > > Commit message:
> > >=20
> > > Refactor auto-quirk solution so that we break as few external
> > > drivers as possible.
> > >=20
> > > PR:             usb/160299
> > > Approved by:    re (kib)
> > > Suggested by:   rwatson
> > > MFC after:      0 days
> >=20
> > First, can you, please, regenerate the diff for stable/8 against the
> > code before r225458 ? I want to read diff to see ABI change, assuming
> > r225458 was not done at all.
> >=20
> > Second, you cannot decrement __FreeBSD_version. In fact, you shall
> > increment it once more in the patch for stable/8.
>=20
> Ok.
>=20
> Please find attached output from:
>=20
> svn diff -r 225457 sys/

For me, it looks fine. Thank you.

--j4NZwBEUS1+1fgbv
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)

iEYEARECAAYFAk5rgzIACgkQC3+MBN1Mb4i5zgCgh9IPhqLP+C5z2t38F9mG18u+
FFYAn3y+HEP1C3MSduZ6Us4fz3H1hhV6
=u5W0
-----END PGP SIGNATURE-----

--j4NZwBEUS1+1fgbv--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110910153306.GP17489>