From owner-freebsd-hackers@FreeBSD.ORG  Tue Mar  4 20:58:09 2008
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E7FCF1065671
	for <hackers@freebsd.org>; Tue,  4 Mar 2008 20:58:09 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id A60428FC12
	for <hackers@freebsd.org>; Tue,  4 Mar 2008 20:58:09 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m24KuaQv075077;
	Tue, 4 Mar 2008 13:56:36 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Tue, 04 Mar 2008 13:57:05 -0700 (MST)
Message-Id: <20080304.135705.1179136136.imp@bsdimp.com>
To: hch@infradead.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20080304200453.GA10987@infradead.org>
References: <20080303.224256.635730757.imp@bsdimp.com>
	<20080304200453.GA10987@infradead.org>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: hackers@freebsd.org
Subject: Re: Comments on pmake diffs for building on Linux
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Mar 2008 20:58:10 -0000

In message: <20080304200453.GA10987@infradead.org>
            Christoph Hellwig <hch@infradead.org> writes:
: On Mon, Mar 03, 2008 at 10:42:56PM -0700, M. Warner Losh wrote:
: > +#ifndef TAILQ_HEAD_INITIALIZER
: > +#define TAILQ_HEAD_INITIALIZER(head) { NULL, &(head).tqh_first }
: > +#endif
: > +
: > +#ifndef TAILQ_FOREACH
: > +#define	TAILQ_FOREACH(var, head, field)					\
: > +	for ((var) = TAILQ_FIRST((head));				\
: > +	    (var);							\
: > +	    (var) = TAILQ_NEXT((var), field))
: > +#endif
: 
: ...
: 
: I think you might be better off with a shadow include/ directory
: that provides a current sys/queue.h on Linux which is what quite a few
: other packages do. I've tried updating the on in glibc a few years ago
: but the maintainer refused to take it.

OK.  I think I'll go this route because doing so I have even fewer
changes necessary.

btw, did he give a reason?

Warner