Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 07 Mar 2015 08:16:59 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 198379] net/liboping: Update to 1.8.0, Fix MASTER_SITES, WWW, Request MAINTAINER'ship
Message-ID:  <bug-198379-13-bmoB0Du5Ve@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-198379-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-198379-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198379

--- Comment #8 from Kubilay Kocak <koobs@FreeBSD.org> ---
Thanks for the update Chris!

1) Add USES=pathfix to fix:

pkg-plist: +lib/pkgconfig/liboping.pc

The correct location for .pc files is:

+libdata/pkgconfig/liboping.pc

portlint(8) should have picked that up.

See: Mk/Uses/pathfix.mk

2) I still believe the original COMMENT is much better as it matches upstream.
Minor issue I know, but I personally have a *very* strong preference to have
ports reflect upstream information as closely as possible for user confidence.

3) As per original review: STRIP_CMD should take place in post-install. There
is still a pre-install: STRIP_CMD

4) While you're there, and if you haven't already:

Add DEVELOPER=yes in /etc/make.conf to enable extra QA/Sanity checks:

See: Mk/bsd.sanity.mk

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-198379-13-bmoB0Du5Ve>