From owner-svn-src-all@FreeBSD.ORG Fri Jan 2 09:48:53 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 33C3C35E for ; Fri, 2 Jan 2015 09:48:53 +0000 (UTC) Received: from o1.l99.sendgrid.net (o1.l99.sendgrid.net [198.37.153.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CECEE1358 for ; Fri, 2 Jan 2015 09:48:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.info; h=from:mime-version:to:subject:references:in-reply-to:content-type:content-transfer-encoding; s=smtpapi; bh=ddM3cQjS7/IQGXOv3qyZSt9bRKc=; b=EohF2X4/BbS0geZS/f PJRcWC/Q7FM2Aw5DfMrIk6AKehxzxhtlB4ZkygbfUonHdaqUMXqAdbej7H6czXG9 lYtlxw+jMXQirQF9rV9PA2rPX+s/dUeUqlU78S36+kdFuYFFoHVakB34zftUhoqT NUVkW8WETRw3R7tte+v7MuUd8= Received: by filter0111p1mdw1.sendgrid.net with SMTP id filter0111p1mdw1.30603.54A6697F2 2015-01-02 09:48:47.931261848 +0000 UTC Received: from mail.tarsnap.com (unknown [10.100.60.97]) by ismtpd-024 (SG) with ESMTP id 14aaa0c1b7e.53e7.14861d for ; Fri, 02 Jan 2015 09:48:47 +0000 (UTC) Received: (qmail 24994 invoked from network); 2 Jan 2015 09:48:33 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by ec2-107-20-205-189.compute-1.amazonaws.com with ESMTP; 2 Jan 2015 09:48:33 -0000 Received: (qmail 16024 invoked from network); 2 Jan 2015 09:48:40 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by clamshell.daemonology.net with SMTP; 2 Jan 2015 09:48:40 -0000 Message-ID: <54A66978.1070108@freebsd.org> Date: Fri, 02 Jan 2015 01:48:40 -0800 From: Colin Percival User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Hans Petter Selasky , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: Re: svn commit: r276530 - head/sys/x86/xen References: <201501020842.t028gjxm080990@svn.freebsd.org> In-Reply-To: <201501020842.t028gjxm080990@svn.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SG-EID: A6W2xSVPHetogaU8rnzccWwgBYtN+QvIzXyjfe/10PG7rGkRJN3EjF7qU06DqZX4DcyPpX432VSVBX u73laOPlZCIgU7YqirtlXjSS3pIgdJJ/ckrtRMJq0j66fnfUjQPV6EqzKU0spINcYs6taAr3qVSO4Y fgqCfV+X0joWQ4oC+6Eewg25Hk8y+6pv1N34 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jan 2015 09:48:53 -0000 On 01/02/15 00:42, Hans Petter Selasky wrote: > Author: hselasky > Date: Fri Jan 2 08:42:44 2015 > New Revision: 276530 > URL: https://svnweb.freebsd.org/changeset/base/276530 > > Log: > Fix warning about possible use of uninitialized variable. Looks to me like the right solution here would be to add bool initial_domain = xen_initial_domain(); and then s/xen_initial_domain()/initial_domain/ in the rest of the function. That should make it clear to static analysis tools that acpi_dev will not be used uninitialized -- since the problem right now is that they don't know that xen_initial_domain() always returns the same value -- without having a bogus initialization which could hide a future bug. -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid