From owner-cvs-all@FreeBSD.ORG  Sat Aug 30 03:20:47 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7407B16A4BF; Sat, 30 Aug 2003 03:20:47 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 602EE43FDD; Sat, 30 Aug 2003 03:20:43 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id UAA30473;
	Sat, 30 Aug 2003 20:20:38 +1000
Date: Sat, 30 Aug 2003 20:20:37 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?= <des@des.no>
In-Reply-To: <xzp1xv4cd93.fsf@dwp.des.no>
Message-ID: <20030830200408.I3440@gamplex.bde.org>
References: <200308240242.h7O2g1Eb085767@repoman.freebsd.org>
 <xzp1xv4cd93.fsf@dwp.des.no>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=X-UNKNOWN
Content-Transfer-Encoding: QUOTED-PRINTABLE
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: Jake Burkholder <jake@FreeBSD.org>
Subject: Re: cvs commit: src/sys/dev/fb fb.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Aug 2003 10:20:47 -0000

On Sat, 30 Aug 2003, Dag-Erling [iso-8859-1] Sm=F8rgrav wrote:

> Jake Burkholder <jake@FreeBSD.org> writes:
> >   Log:
> >   Changed ??? to foo in dead code since ??? screws up my editor.
>
> ??? also confuses the compiler ("invalid trigraph blah blah") and
> should be avoided in C code.

Actually, "???" is a valid non-trigraph that doesn't confuse C compilers.
It just sometomes forms a trigraph when mixed with other punctuation.
E.g., "???)" forms the character "?" followed by the trigraph "??)".
So "???)" is converted to "?]" by C compilers.

In fb.c, "???" was followed by ",", so it was just a syntax error (one
of many bugs in the dead code).

Bruce