From owner-cvs-all@FreeBSD.ORG Fri Aug 4 15:36:05 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E82716A65A; Fri, 4 Aug 2006 15:36:05 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6044E43D49; Fri, 4 Aug 2006 15:36:04 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k74FZnG1003112; Fri, 4 Aug 2006 11:35:51 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Yar Tikhiy Date: Fri, 4 Aug 2006 11:03:05 -0400 User-Agent: KMail/1.9.1 References: <200608031905.k73J55D2061870@repoman.freebsd.org> <20060804072323.GC89735@wombat.fafoe.narf.at> <20060804074657.GT97316@comp.chem.msu.su> In-Reply-To: <20060804074657.GT97316@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200608041103.06045.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 04 Aug 2006 11:35:51 -0400 (EDT) X-Virus-Scanned: ClamAV version 0.87.1, clamav-milter version 0.87 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: cvs-src@freebsd.org, Stefan Farfeleder , pdeuskar@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 15:36:05 -0000 On Friday 04 August 2006 03:46, Yar Tikhiy wrote: > On Fri, Aug 04, 2006 at 09:23:23AM +0200, Stefan Farfeleder wrote: > > On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote: > > > > > > As a general remark, it is a very good idea to keep large style(9) > > > sweeps separate from actual code changes even if they are tiny. > > > Changing style(9) shouldn't alter the binary code produced, and > > > this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). > > > Of course, changing line numbers will affect debug info, but the > > > latter can be strip(1)'ed. In the case under discussion, I'd compare > > > if_em.o with its former version to make sure no code changed. > > > > It will produce different code if __LINE__ is used. > > Yeah, it's a thing to watch out for. As are __TIME__ and __DATE__. > Fortunately, they are not widely used in src/, AFAIK. If you have INVARIANTS on then every mtx_lock/unlock will include __LINE__ and __FILE__. -- John Baldwin